Declare release JSON schema as a static field

Author: isaacroldan

bin/prettify-manifests.js

@@ -13,6 +13,11 @@ const manifestFiles = glob.sync(`packages/*/oclif.manifest.json`)
 for (const file of manifestFiles) {
   console.log(`Prettifying ${file}...`)
   const content = fs.readFileSync(file)
-  const prettyContent = stringify(JSON.parse(content), {space: '  '}).replaceAll(root, '.')
+  const manifest = JSON.parse(content)
+  for (const command of Object.values(manifest.commands)) {
+    // Runtime schemas belong to command classes, not cached metadata.
+    delete command.jsonOutputSchema
+  }
+  const prettyContent = stringify(manifest, {space: '  '}).replaceAll(root, '.')
   fs.writeFileSync(file, prettyContent)
 }

packages/app/src/cli/commands/app/release.ts

@@ -18,9 +18,7 @@ export default class Release extends AppLinkedCommand {
 
   static descriptionWithMarkdown = `Releases an existing app version. Pass the name of the version that you want to release using the \`--version\` flag.`
 
-  static get jsonOutputSchema() {
-    return appReleaseJsonOutputSchema
-  }
+  static jsonOutputSchema = appReleaseJsonOutputSchema
 
   static description = this.descriptionForHelp()
 

packages/eslint-plugin-cli/rules/command-json-output.js

@@ -62,7 +62,9 @@ function repositoryPath(filename) {
 function hasJsonOutputSchema(classMembers) {
   return classMembers.some(
     (member) =>
-      member.type === 'MethodDefinition' && member.kind === 'get' && isStaticMemberNamed(member, 'jsonOutputSchema'),
+      isStaticMemberNamed(member, 'jsonOutputSchema') &&
+      ((member.type === 'MethodDefinition' && member.kind === 'get') ||
+        (member.type === 'PropertyDefinition' && Boolean(member.value))),
   )
 }
 

packages/eslint-plugin-cli/rules/command-json-output.test.js

@@ -37,9 +37,7 @@ ruleTester.run('command-json-output', rule, {
       code: `
         export default class WidgetDelete extends Command {
           static flags = {...globalFlags, ...jsonFlag}
-          static get jsonOutputSchema() {
-            return widgetDeleteJsonOutputSchema
-          }
+          static jsonOutputSchema = widgetDeleteJsonOutputSchema
         }
       `,
     },