Make Oxlint the primary linter

Author: gonzaloriestra

.github/workflows/tests-main.yml

@@ -51,8 +51,8 @@ jobs:
       - name: Oxlint
         run: pnpm lint:oxlint
         if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '26.1.0' }}
-      - name: Lint
-        run: pnpm nx run-many --all --target=lint --output-style=stream
+      - name: ESLint compatibility
+        run: pnpm lint:eslint --output-style=stream
         if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '26.1.0' }}
       - name: Type-check
         run: pnpm nx run-many --all --target=type-check --output-style=stream

.github/workflows/tests-pr.yml

@@ -55,8 +55,8 @@ jobs:
         run: pnpm prettier
       - name: Oxlint
         run: pnpm lint:oxlint
-      - name: Lint
-        run: pnpm nx run-many --all --target=lint --output-style=stream
+      - name: ESLint compatibility
+        run: pnpm lint:eslint --output-style=stream
 
   bundle:
     name: 'Bundle'

docs/cli/get-started.md

@@ -70,8 +70,8 @@ Besides the scripts for building and running the CLIs, there are others that mig
 - `pnpm test`: Runs the tests of all the packages.
 - `pnpm prettier`: Checks formatting for all linted source files.
 - `pnpm prettier:fix`: Formats all linted source files.
-- `pnpm lint`: Runs Prettier, Oxlint, and ESLint checks for all the packages.
-- `pnpm lint:fix`: Runs Prettier and ESLint for all the packages and fixes the fixable issues.
+- `pnpm lint`: Runs Prettier, Oxlint, and ESLint compatibility checks for all the packages.
+- `pnpm lint:fix`: Runs Prettier, Oxlint, and ESLint compatibility checks and fixes supported issues.
 - `pnpm type-check`: Type-checks all the packagesusing the Typescript `tsc` tool.
 - `pnpm clean`: Removes the `dist` directory from all the packages.
 

eslint.codegen.config.js

@@ -0,0 +1,4 @@
+import {eslintBaseConfig} from './eslint.config.js'
+
+// Generated GraphQL output relies on the full ESLint autofix behavior to remain deterministic.
+export default eslintBaseConfig

eslint.config.js

@@ -1,9 +1,38 @@
 import nxPlugin from '@nx/eslint-plugin'
 import cliPlugin from '@shopify/eslint-plugin-cli'
 import jsdocPlugin from 'eslint-plugin-jsdoc'
+import {readFileSync} from 'node:fs'
+
+const oxlintConfig = JSON.parse(readFileSync(new URL('./oxlint.json', import.meta.url), 'utf8'))
+
+const eslintPluginNames = {
+  import: 'import-x',
+  node: 'n',
+  typescript: '@typescript-eslint',
+}
+
+const eslintRuleName = (oxlintRuleName) => {
+  const [pluginName, ...ruleNameParts] = oxlintRuleName.split('/')
+  const eslintPluginName = eslintPluginNames[pluginName]
+  return eslintPluginName ? `${eslintPluginName}/${ruleNameParts.join('/')}` : oxlintRuleName
+}
+
+const isEnabled = (ruleConfiguration) => {
+  const severity = Array.isArray(ruleConfiguration) ? ruleConfiguration[0] : ruleConfiguration
+  return severity !== 'off' && severity !== 0
+}
+
+const eslintCompatibilityConfig = ({files, rules}) => ({
+  ...(files ? {files} : {}),
+  rules: Object.fromEntries(
+    Object.entries(rules)
+      .filter(([, ruleConfiguration]) => isEnabled(ruleConfiguration))
+      .map(([ruleName]) => [eslintRuleName(ruleName), 'off']),
+  ),
+})
 
 // Spread the CLI plugin's base config which includes all necessary plugins
-const config = [
+export const eslintBaseConfig = [
   // Base config from @shopify/eslint-plugin-cli (includes shopify, typescript, prettier, etc.)
   ...cliPlugin.configs.config,
 
@@ -243,4 +272,17 @@ const config = [
   },
 ]
 
+const config = [
+  ...eslintBaseConfig,
+  // ESLint remains as a compatibility layer for rules that Oxlint does not support yet.
+  // A directive can target an Oxlint-owned rule, so ESLint alone cannot determine whether it is unused.
+  {
+    linterOptions: {
+      reportUnusedDisableDirectives: 'off',
+    },
+  },
+  eslintCompatibilityConfig(oxlintConfig),
+  ...oxlintConfig.overrides.map((override) => eslintCompatibilityConfig(override)),
+]
+
 export default config

package.json

@@ -17,10 +17,12 @@
     "graphql-codegen:get-graphql-schemas": "bin/get-graphql-schemas.js",
     "graphql-codegen": "nx run-many --target=graphql-codegen --all",
     "knip": "knip",
-    "lint:affected": "pnpm prettier && pnpm lint:oxlint && nx affected --target=lint",
-    "lint:fix:affected": "pnpm prettier:fix && nx affected --target=lint:fix",
-    "lint:fix": "pnpm prettier:fix && nx run-many --target=lint:fix --all --skip-nx-cache",
-    "lint": "pnpm prettier && pnpm lint:oxlint && nx run-many --target=lint --all",
+    "lint:affected": "pnpm prettier && pnpm lint:oxlint && pnpm lint:eslint:affected",
+    "lint:eslint:affected": "nx affected --target=lint",
+    "lint:fix:affected": "pnpm prettier:fix && pnpm lint:oxlint --fix && nx affected --target=lint:fix",
+    "lint:fix": "pnpm prettier:fix && pnpm lint:oxlint --fix && nx run-many --target=lint:fix --all --skip-nx-cache",
+    "lint": "pnpm prettier && pnpm lint:oxlint && pnpm lint:eslint",
+    "lint:eslint": "nx run-many --target=lint --all",
     "lint:oxlint": "oxlint --config oxlint.json --deny-warnings packages/app/src packages/cli-kit/src packages/cli/src packages/create-app/src packages/organizations/src packages/plugin-cloudflare/src packages/plugin-did-you-mean/src packages/store/src packages/theme/src packages/ui-extensions-server-kit/src packages/ui-extensions-test-utils/src packages/cli/bin packages/e2e",
     "prettier": "prettier --check \"packages/{app,cli-kit,cli,create-app,organizations,plugin-cloudflare,plugin-did-you-mean,store,theme,ui-extensions-server-kit,ui-extensions-test-utils}/src/**/*.{js,ts,tsx}\" \"packages/cli/bin/*.js\" \"packages/e2e/{setup,helpers,tests}/**/*.ts\" \"packages/e2e/*.ts\"",
     "prettier:fix": "prettier --write \"packages/{app,cli-kit,cli,create-app,organizations,plugin-cloudflare,plugin-did-you-mean,store,theme,ui-extensions-server-kit,ui-extensions-test-utils}/src/**/*.{js,ts,tsx}\" \"packages/cli/bin/*.js\" \"packages/e2e/{setup,helpers,tests}/**/*.ts\" \"packages/e2e/*.ts\"",
@@ -191,7 +193,8 @@
       ".": {
         "entry": [
           "bin/**/*.js",
-          "configurations/vite.config.ts"
+          "configurations/vite.config.ts",
+          "eslint.codegen.config.js"
         ],
         "ignoreBinaries": [
           "bin/*",

packages/app/project.json

@@ -74,13 +74,13 @@
       ],
       "options": {
         "commands": [
-          "pnpm eslint 'src/cli/api/graphql/business-platform-destinations/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/business-platform-destinations/generated/**/*.{ts,tsx}'",
-          "pnpm eslint 'src/cli/api/graphql/business-platform-organizations/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/business-platform-organizations/generated/**/*.{ts,tsx}'",
-          "pnpm eslint 'src/cli/api/graphql/app-dev/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/app-dev/generated/**/*.{ts,tsx}'",
-          "pnpm eslint 'src/cli/api/graphql/app-management/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/app-management/generated/**/*.{ts,tsx}'",
-          "pnpm eslint 'src/cli/api/graphql/webhooks/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/webhooks/generated/**/*.{ts,tsx}'",
-          "pnpm eslint 'src/cli/api/graphql/functions/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/functions/generated/**/*.{ts,tsx}'",
-          "pnpm eslint 'src/cli/api/graphql/admin/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/admin/generated/**/*.{ts,tsx}'"
+          "pnpm eslint --config ../../eslint.codegen.config.js 'src/cli/api/graphql/business-platform-destinations/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/business-platform-destinations/generated/**/*.{ts,tsx}'",
+          "pnpm eslint --config ../../eslint.codegen.config.js 'src/cli/api/graphql/business-platform-organizations/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/business-platform-organizations/generated/**/*.{ts,tsx}'",
+          "pnpm eslint --config ../../eslint.codegen.config.js 'src/cli/api/graphql/app-dev/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/app-dev/generated/**/*.{ts,tsx}'",
+          "pnpm eslint --config ../../eslint.codegen.config.js 'src/cli/api/graphql/app-management/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/app-management/generated/**/*.{ts,tsx}'",
+          "pnpm eslint --config ../../eslint.codegen.config.js 'src/cli/api/graphql/webhooks/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/webhooks/generated/**/*.{ts,tsx}'",
+          "pnpm eslint --config ../../eslint.codegen.config.js 'src/cli/api/graphql/functions/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/functions/generated/**/*.{ts,tsx}'",
+          "pnpm eslint --config ../../eslint.codegen.config.js 'src/cli/api/graphql/admin/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/admin/generated/**/*.{ts,tsx}'"
         ],
         "cwd": "packages/app"
       }

packages/cli-kit/project.json

@@ -109,8 +109,8 @@
       ],
       "options": {
         "commands": [
-          "pnpm eslint 'src/cli/api/graphql/admin/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/admin/generated/**/*.{ts,tsx}'",
-          "pnpm eslint 'src/cli/api/graphql/bulk-operations/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/bulk-operations/generated/**/*.{ts,tsx}'"
+          "pnpm eslint --config ../../eslint.codegen.config.js 'src/cli/api/graphql/admin/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/admin/generated/**/*.{ts,tsx}'",
+          "pnpm eslint --config ../../eslint.codegen.config.js 'src/cli/api/graphql/bulk-operations/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/bulk-operations/generated/**/*.{ts,tsx}'"
         ],
         "cwd": "packages/cli-kit"
       }

packages/organizations/project.json

@@ -53,8 +53,8 @@
       ],
       "options": {
         "commands": [
-          "pnpm eslint 'src/cli/api/graphql/business-platform-destinations/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/business-platform-destinations/generated/**/*.{ts,tsx}'",
-          "pnpm eslint 'src/cli/api/graphql/business-platform-organizations/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/business-platform-organizations/generated/**/*.{ts,tsx}'"
+          "pnpm eslint --config ../../eslint.codegen.config.js 'src/cli/api/graphql/business-platform-destinations/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/business-platform-destinations/generated/**/*.{ts,tsx}'",
+          "pnpm eslint --config ../../eslint.codegen.config.js 'src/cli/api/graphql/business-platform-organizations/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/business-platform-organizations/generated/**/*.{ts,tsx}'"
         ],
         "cwd": "packages/organizations"
       }

packages/store/project.json

@@ -54,8 +54,8 @@
       ],
       "options": {
         "commands": [
-          "pnpm eslint 'src/cli/api/graphql/business-platform-destinations/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/business-platform-destinations/generated/**/*.{ts,tsx}'",
-          "pnpm eslint 'src/cli/api/graphql/business-platform-organizations/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/business-platform-organizations/generated/**/*.{ts,tsx}'"
+          "pnpm eslint --config ../../eslint.codegen.config.js 'src/cli/api/graphql/business-platform-destinations/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/business-platform-destinations/generated/**/*.{ts,tsx}'",
+          "pnpm eslint --config ../../eslint.codegen.config.js 'src/cli/api/graphql/business-platform-organizations/generated/**/*.{ts,tsx}' --fix && pnpm exec prettier --write --ignore-path ../../.prettierignore 'src/cli/api/graphql/business-platform-organizations/generated/**/*.{ts,tsx}'"
         ],
         "cwd": "packages/store"
       }