Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CPP code in favor of numba #27

Open
cbespin opened this issue Dec 15, 2022 · 3 comments
Open

Remove CPP code in favor of numba #27

cbespin opened this issue Dec 15, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@cbespin
Copy link
Contributor

cbespin commented Dec 15, 2022

Browsing the code, I noticed usage of Cython functions for histogramming and array operations. Maybe those can be ported to numba to remove the cython/cpp dependency, making this project pure python.
If this is considered useful, I am willing to do a speed comparison and provide a PR when I find the time.

@cbespin cbespin added the enhancement New feature or request label Dec 15, 2022
@leloup314
Copy link
Member

leloup314 commented Dec 15, 2022

Sounds nice to me ;) Maybe you have the time to look at the pylandau numba port (which is essential done) and check if this is fine? This uses AOT instead of a (probably) faster JIT approach

@cbespin
Copy link
Contributor Author

cbespin commented Dec 15, 2022

Yes, I will (come time). The same can probably applied here, if it proves as an advantage.

@YannickDieter
Copy link
Collaborator

I like the idea. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants