Something wrong with contract statuses?

[NickJH]

Current Behavior

Please see this screenshot:

The bottom two contracts say active, finishing on 18/01, paying out on 20/01. The both have been renewed to other contracts. Shouldn't they be Complete or Renewed?

Contracts are 24f9ede7de6b61ddbc74aa8ea88cdff49cdef64f3fa4348c76b861fbad58f874 and 405b75eab11aec2a4adf7cf874e63a7d86434d011700e9132c3f356e93610bea.

Expected Behavior

If the contracts have completed, they should show Complete. If they have been renewed, they should show Renewed. I don't see any way a renewed contract should be showing Active.

Steps to Reproduce

No response

Version

v2.5.1

Anything else?

No response

[n8mgr]

This bug occurs when a revision and resolution are confirmed in the same block. It doesn't affect the actual payout, just the state flag. It's a relatively easy fix. We should also be sure we're handling this edge case in all the other apps. It looks like explored is fine.

I'm not 100% we can fix the state flag without triggering a rescan of the chain.

[ChrisSchinnerl]

@n8mgr can we close this? It was fixed for hostd, SiaFoundation/renterd#2045 confirms that it's not an issue in renterd and for indexd we got a separate tracking issue SiaFoundation/indexd#853.

[NickJH]

@ChrisSchinnerl Please don't close the issue as it is not fixed. Please see the screenshot:

[n8mgr]

@ChrisSchinnerl we fixed the underlying issue, but we didn't fix the issue for existing contracts. I was hoping to find a solution without rescanning before closing this.

[NickJH]

Possibly in a similar way you do database upgrades, could you include a little script to update the relevant database entries in order to avoid a full rescan of the database?