Skip to content

Commit c9f8fa2

Browse files
committed
cleanup
1 parent d78e0c5 commit c9f8fa2

File tree

10 files changed

+7
-43
lines changed

10 files changed

+7
-43
lines changed

.DS_Store

-6 KB
Binary file not shown.

packages/sqlite_async/lib/src/common/connection/sync_sqlite_connection.dart

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,6 @@ class SyncSqliteConnection extends SqliteConnection with SqliteQueries {
5050
Future<bool> getAutoCommit() async {
5151
return db.autocommit;
5252
}
53-
54-
@override
55-
int getNumConnections() {
56-
return -1;
57-
}
5853
}
5954

6055
class SyncReadContext implements SqliteReadContext {

packages/sqlite_async/lib/src/impl/single_connection_database.dart

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,6 @@ final class SingleConnectionDatabase
6363
return [connection];
6464
}
6565

66-
@override
67-
int getNumConnections() {
68-
return 1;
69-
}
70-
7166
@override
7267
int get numConnections => 1;
7368
}

packages/sqlite_async/lib/src/impl/stub_sqlite_database.dart

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,6 @@ class SqliteDatabaseImpl
6868
@override
6969
int get numConnections => throw UnimplementedError();
7070

71-
@override
72-
int getNumConnections() {
73-
throw UnimplementedError();
74-
}
75-
7671
@override
7772
List<SqliteConnection> getAllConnections() {
7873
throw UnimplementedError();

packages/sqlite_async/lib/src/native/database/connection_pool.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,8 +243,8 @@ class SqliteConnectionPool with SqliteQueries implements SqliteConnection {
243243
}
244244

245245
int getNumConnections() {
246-
print(
247-
"TESTING READ: ${_allReadConnections.length} WRITE: ${_writeConnection == null ? 0 : 1}");
246+
// print(
247+
// "TESTING READ: ${_allReadConnections.length} WRITE: ${_writeConnection == null ? 0 : 1}");
248248
return _allReadConnections.length + (_writeConnection == null ? 0 : 1);
249249
}
250250
}

packages/sqlite_async/lib/src/native/database/native_sqlite_connection_impl.dart

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ class SqliteConnectionImpl
9595

9696
@override
9797
Future<void> close() async {
98-
print("Closing native sqlite Connection ${StackTrace.current}");
98+
// print("Closing native sqlite Connection ${StackTrace.current}");
9999
eventsPort?.close();
100100
await _connectionMutex.lock(() async {
101101
if (readOnly) {
@@ -159,11 +159,6 @@ class SqliteConnectionImpl
159159
});
160160
}, timeout: lockTimeout);
161161
}
162-
163-
@override
164-
int getNumConnections() {
165-
return -1;
166-
}
167162
}
168163

169164
int _nextCtxId = 1;

packages/sqlite_async/lib/src/native/database/native_sqlite_database.dart

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ class SqliteDatabaseImpl
4040
late final SqliteConnectionImpl _internalConnection;
4141
late final SqliteConnectionPool _pool;
4242

43-
@override
44-
int get numConnections => _pool.getNumConnections();
45-
4643
final StreamController<UpdateNotification> updatesController =
4744
StreamController.broadcast();
4845

@@ -176,9 +173,7 @@ class SqliteDatabaseImpl
176173
}
177174

178175
@override
179-
int getNumConnections() {
180-
return -1;
181-
}
176+
int get numConnections => _pool.getNumConnections();
182177

183178
@override
184179
List<SqliteConnection> getAllConnections() {

packages/sqlite_async/lib/src/sqlite_connection.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,8 +157,6 @@ abstract class SqliteConnection extends SqliteWriteContext {
157157
/// Queries and watch calls can potentially use outdated schema information after a schema update.
158158
Future<void> refreshSchema();
159159

160-
int getNumConnections();
161-
162160
/// Returns true if the connection is closed
163161
@override
164162
bool get closed;

packages/sqlite_async/lib/src/web/database.dart

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -170,12 +170,8 @@ class WebDatabase
170170
return _database.fileSystem.flush();
171171
}
172172
@override
173-
int get numConnections => 0;
173+
int get numConnections => throw UnimplementedError();
174174

175-
@override
176-
int getNumConnections() {
177-
return -1;
178-
}
179175

180176
@override
181177
List<SqliteConnection> getAllConnections() {

packages/sqlite_async/lib/src/web/database/web_sqlite_database.dart

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -181,16 +181,11 @@ class SqliteDatabaseImpl
181181
return await _connection.exposeEndpoint();
182182
}
183183
@override
184-
int get numConnections => 0;
185-
186-
@override
187-
int getNumConnections() {
188-
return -1;
189-
}
184+
int get numConnections => 1;
190185

191186
@override
192187
List<SqliteConnection> getAllConnections() {
193-
throw UnimplementedError();
188+
return [_connection];
194189
}
195190

196191

0 commit comments

Comments
 (0)