Merge pull request #13 from SkyLightQP/develop

fix: update `meta` and `script` tags
SkyLightQP · Apr 28, 2024 · f835f5e · f835f5e
2 parents 8f99e0b + 6624076
commit f835f5e
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 30 deletions.
diff --git a/README.md b/README.md
@@ -1,4 +1,4 @@
-# daegyeo.me [![CodeFactor](https://www.codefactor.io/repository/github/skylightqp/daegyeo.me/badge)](https://www.codefactor.io/repository/github/skylightqp/daegyeo.me)
+# daegyeo.me [![deploy-web](https://github.com/SkyLightQP/daegyeo.me/actions/workflows/deploy-web.yml/badge.svg?branch=main)](https://github.com/SkyLightQP/daegyeo.me/actions/workflows/deploy-web.yml) [![CodeFactor](https://www.codefactor.io/repository/github/skylightqp/daegyeo.me/badge)](https://www.codefactor.io/repository/github/skylightqp/daegyeo.me) 
 
 - [daegyeo.me](https://daegyeo.me/)
 - [skylightqp.kr](https://skylightqp.kr/)

diff --git a/package.json b/package.json
@@ -20,6 +20,7 @@
     "@fortawesome/free-regular-svg-icons": "^6.3.0",
     "@fortawesome/free-solid-svg-icons": "^6.3.0",
     "@fortawesome/react-fontawesome": "^0.2.0",
+    "@next/third-parties": "^14.2.3",
     "@supabase/auth-helpers-nextjs": "^0.9.0",
     "@supabase/auth-helpers-react": "^0.4.2",
     "@supabase/supabase-js": "^2.39.7",

diff --git a/src/pages/_app.tsx b/src/pages/_app.tsx
@@ -2,7 +2,6 @@ import React, { useEffect, useState } from 'react';
 import { AppProps } from 'next/app';
 import { ChakraProvider } from '@chakra-ui/react';
 import Head from 'next/head';
-import Script from 'next/script';
 import { createPagesBrowserClient, Session } from '@supabase/auth-helpers-nextjs';
 import { SessionContextProvider } from '@supabase/auth-helpers-react';
 import GlobalStyle from '../styles/GlobalStyle';
@@ -25,27 +24,7 @@ const App = ({
     <>
       <Head>
         <title>하대겸 | Daegyeom Ha</title>
-        <meta name="viewport" content="width=device-width, initial-scale=1" />
       </Head>
-      <Script
-        src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js?client=ca-pub-2490453096003621"
-        strategy="afterInteractive"
-        crossOrigin="anonymous"
-      />
-      <Script src="https://www.googletagmanager.com/gtag/js?id=G-J0FQZH7MNY" strategy="afterInteractive" />
-      <Script
-        id="google-analytics"
-        strategy="afterInteractive"
-        dangerouslySetInnerHTML={{
-          __html: `
-            window.dataLayer = window.dataLayer || [];
-            function gtag(){dataLayer.push(arguments);}
-            gtag('js', new Date());
-  
-            gtag('config', 'G-J0FQZH7MNY');
-            `
-        }}
-      />
       <SessionContextProvider supabaseClient={supabaseClient} initialSession={pageProps.initialSession}>
         <ChakraProvider>
           <GlobalStyle />

diff --git a/src/pages/_document.tsx b/src/pages/_document.tsx
@@ -1,18 +1,31 @@
 import React from 'react';
 import { Head, Html, Main, NextScript } from 'next/document';
+import { GoogleAnalytics } from '@next/third-parties/google';
 import Colors from '../styles/Colors';
 
 const Document = () => {
   return (
     <Html lang="ko">
       <Head>
+        <script
+          src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js?client=ca-pub-2490453096003621"
+          crossOrigin="anonymous"
+          async
+        />
+        <GoogleAnalytics gaId="G-J0FQZH7MNY" />
+
+        <meta name="viewport" content="width=device-width, initial-scale=1" />
+
         <meta charSet="utf-8" />
+
         <link rel="icon" href="favicon.ico" />
         <link rel="apple-touch-icon" href="favicon.ico" />
+
         <meta name="author" content="하대겸" />
-        <meta name="keywords" content="Daegyeom Ha, 하대겸, Resume, Portfolio, 포트폴리오" />
+        <meta name="keywords" content="Daegyeom Ha, 하대겸, daegyeome, daegyeo.me" />
         <meta name="theme-color" content={Colors.PRIMARY} />
         <meta name="description" content="Resume of Daegyeom Ha" />
+
         <meta property="og:site_name" content="하대겸 | Daegyeom Ha" />
         <meta property="og:type" content="website" />
         <meta property="og:title" content="하대겸 | Daegyeom Ha" />

diff --git a/yarn.lock b/yarn.lock
@@ -85,13 +85,6 @@
   dependencies:
     regenerator-runtime "^0.13.4"
 
-"@babel/runtime@^7.12.5":
-  version "7.24.0"
-  resolved "https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.24.0.tgz#584c450063ffda59697021430cb47101b085951e"
-  integrity sha512-Chk32uHMg6TnQdvw2e9IlqPpFX/6NLuK0Ys2PqLb7/gL5uFn9mXvK715FGLlOLQrcO4qIkNHkvPGktzzXexsFw==
-  dependencies:
-    regenerator-runtime "^0.14.0"
-
 "@babel/runtime@^7.7.2":
   version "7.12.5"
   resolved "https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.12.5.tgz#410e7e487441e1b360c29be715d870d9b985882e"
@@ -1027,6 +1020,13 @@
   resolved "https://registry.yarnpkg.com/@next/swc-win32-x64-msvc/-/swc-win32-x64-msvc-14.1.0.tgz#e561fb330466d41807123d932b365cf3d33ceba2"
   integrity sha512-9WEbVRRAqJ3YFVqEZIxUqkiO8l1nool1LmNxygr5HWF8AcSYsEpneUDhmjUVJEzO2A04+oPtZdombzzPPkTtgg==
 
+"@next/third-parties@^14.2.3":
+  version "14.2.3"
+  resolved "https://registry.yarnpkg.com/@next/third-parties/-/third-parties-14.2.3.tgz#2e72d9fa456c1155700082ab40ac68018e9ec5d2"
+  integrity sha512-j4E2xBSsEZq4VX2pVm3LpGltSwCxETic6glJWfHyYQvpoMdplCAYrQKpF+E9Gg3jfsrfmRAIdTE11m+biBCx1Q==
+  dependencies:
+    third-party-capital "1.0.20"
+
 "@nodelib/[email protected]":
   version "2.1.5"
   resolved "https://registry.yarnpkg.com/@nodelib/fs.scandir/-/fs.scandir-2.1.5.tgz#7619c2eb21b25483f6d167548b4cfd5a7488c3d5"
@@ -4302,6 +4302,7 @@ streamsearch@^1.1.0:
   integrity sha512-Mcc5wHehp9aXz1ax6bZUyY5afg9u2rv5cqQI3mRrYkGC8rW2hM02jWuwjtL++LS5qinSyhj2QfLyNsuc+VsExg==
 
 "string-width-cjs@npm:string-width@^4.2.0", string-width@^4.1.0:
+  name string-width-cjs
   version "4.2.3"
   resolved "https://registry.yarnpkg.com/string-width/-/string-width-4.2.3.tgz#269c7117d27b05ad2e536830a8ec895ef9c6d010"
   integrity sha512-wKyQRQpjJ0sIp62ErSZdGsjMJWsap5oRNihHhu6G7JVO/9jIB6UyevL+tXuOqrng8j/cxKTWyWUwvSTriiZz/g==
@@ -4472,6 +4473,11 @@ text-table@^0.2.0:
   resolved "https://registry.yarnpkg.com/text-table/-/text-table-0.2.0.tgz#7f5ee823ae805207c00af2df4a84ec3fcfa570b4"
   integrity sha512-N+8UisAXDGk8PFXP4HAzVR9nbfmVJ3zYLAWiTIoqC5v5isinhr+r5uaO8+7r3BMfuNIufIsA7RdpVgacC2cSpw==
 
+[email protected]:
+  version "1.0.20"
+  resolved "https://registry.yarnpkg.com/third-party-capital/-/third-party-capital-1.0.20.tgz#e218a929a35bf4d2245da9addb8ab978d2f41685"
+  integrity sha512-oB7yIimd8SuGptespDAZnNkzIz+NWaJCu2RMsbs4Wmp9zSDUM8Nhi3s2OOcqYuv3mN4hitXc8DVx+LyUmbUDiA==
+
 tiny-invariant@^1.0.6:
   version "1.2.0"
   resolved "https://registry.yarnpkg.com/tiny-invariant/-/tiny-invariant-1.2.0.tgz#a1141f86b672a9148c72e978a19a73b9b94a15a9"