Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need better section names for materials in ProblemDefinition #108

Open
JessicaRehak opened this issue Oct 11, 2018 · 0 comments
Open

Need better section names for materials in ProblemDefinition #108

JessicaRehak opened this issue Oct 11, 2018 · 0 comments
Labels
enhancement Addition of features to BART. minor Isolated within in a single class or function.

Comments

@JessicaRehak
Copy link
Collaborator

ProblemDefinition defines the following sections for material information:

number of materials
subsection material ID map
  material id file name map
  fuel pin material id file name
  material id file name

These should probably be renamed in a way that makes it more clear what each does.

  • material id file name map: map of integers to filenames that contain the material data. (1: mat_1.material, 2: mat_2.material)
  • material id file name: filename of the plaintext file containing the layout of materials in the problem, with id values that match the integers in the material id file name map
  • fuel pin material id file name: same as previous but for fuel pins.

I recommend we update to something like:

subsection materials
  number of materials
  ids to materials filename map
  filename of material layout
  filename of fuel pin material layout
@JessicaRehak JessicaRehak added enhancement Addition of features to BART. minor Isolated within in a single class or function. labels Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Addition of features to BART. minor Isolated within in a single class or function.
Projects
None yet
Development

No branches or pull requests

1 participant