Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angle Indexing #141

Open
JessicaRehak opened this issue Nov 22, 2019 · 0 comments
Open

Angle Indexing #141

JessicaRehak opened this issue Nov 22, 2019 · 0 comments
Labels
enhancement Addition of features to BART. major Involves multiple classes across multiple top level namespaces.

Comments

@JessicaRehak
Copy link
Collaborator

JessicaRehak commented Nov 22, 2019

Solutions and terms in BART are indexed by an integer angle index and a pair of angle and group indices, respectively. The quadrature set implementation supports providing this index for a given quadrature point and vice versa. Ideally, the quadrature point itself (specifically the shared pointer) could be used to index solutions and terms. This causes a large conflicts that may be unsolvable:

  • Quadrature point pointers require a template parameter because QuadraturePointI<dim> requires one.
  • This propagates to TermI which propagates to system::Solution

This then propagates to most of the code, making any part of BART that interacts with the system solution to require a template parameter. This causes a ton of issues, especially with classes that already have template parameters (like stampers).

A better way to do this needs to be determined (perhaps finding a way to remove the template parameter from QuadraturePointI<dim>) so that, ideally, angle indices can be removed.

@JessicaRehak JessicaRehak added enhancement Addition of features to BART. major Involves multiple classes across multiple top level namespaces. labels Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Addition of features to BART. major Involves multiple classes across multiple top level namespaces.
Projects
None yet
Development

No branches or pull requests

1 participant