Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soulbound items disappear when restarting the server mid-deathscreen #3774

Open
4 tasks done
KiinoOFC opened this issue Feb 20, 2023 · 16 comments
Open
4 tasks done

Soulbound items disappear when restarting the server mid-deathscreen #3774

KiinoOFC opened this issue Feb 20, 2023 · 16 comments
Labels
🐞 Bug Report A bug that needs to be fixed. 🧨 Confirmed Bug This bug has been confirmed by our team.

Comments

@KiinoOFC
Copy link

❗ Checklist

  • I am using the official english version of Slimefun and did not modify the jar.
  • I am using an up to date "DEV" (not "RC") version of Slimefun.
  • I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • I searched for similar open issues and could not find an existing bug report on this.

📍 Description

When a player dies with Soulbound items. After restarting the server, the items disappear

📑 Reproduction Steps

  1. Have items with Soulbound
  2. Then you die
  3. Restart the server
  4. Join the server
  5. Checks if Soulbound items are there

💡 Expected Behavior

Soulbound items do not disappear

📷 Screenshots / Videos

Before restarting
image

After restart
image

📜 Server Log

no errors to log

📂 /error-reports/ folder

no errors to folder

💻 Server Software

Paper

🎮 Minecraft Version

1.17.x

⭐ Slimefun version

Paper git-Paper-411 (MC: 1.17.1)
Slimefun DEV - 1043 (git 4bfc4f0)
Metrics-Module #28
Java 17

🧭 Other plugins

No response

@KiinoOFC KiinoOFC added 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. 🐞 Bug Report A bug that needs to be fixed. labels Feb 20, 2023
@Boomer-1
Copy link

Boomer-1 commented Feb 20, 2023

please provide your full plugin list and if you have any datapacks installed

@KiinoOFC
Copy link
Author

OBS: Have to restart server on death screen

no data pack installed
plugins:
image

@Boomer-1
Copy link

over many repeated attempts i cannot duplicate this with 1.17.1 and dev 1043

@Boomer-1
Copy link

what mods are you using?

@KiinoOFC
Copy link
Author

no mod

@Boomer-1
Copy link

well, you have at least one based on the picture you provided of your inventory. something you've installed, in the server or the client is interfering. without all the info we can't help

@KiinoOFC
Copy link
Author

I managed to fix my OBS, maybe this will help

2023-02-20-23-17-31_ydqhLUo4.mp4
2023-02-20.23-19-22.mp4

@KiinoOFC
Copy link
Author

and the server was created from scratch to test this, just with the addition of slimefun

@Boomer-1
Copy link

you have a mod installed. numbers in your inventory is not vanilla

@KiinoOFC
Copy link
Author

texturepack

@Boomer-1
Copy link

with the exact same server, minecraft version and slimefun version i cannot recreate it. I've tried netherite armor, diamond armor and it stays everytime. try removing the pack and do it again

@Boomer-1
Copy link

ok. i think i figured it out. you're shutting your server down before the player clicks respawn. that's the only way i've been able to do it. so in the extreme possibility that the player dies in that millisecond, and they can't click respawn it disappears. in that brief moment between death and the server restart, the event cant fire. iirc, it fires on the click of respawn. because the data can't be saved thru a restart. not sure if there's a fix to that or not. Dev's will have to look into it.

@Boomer-1
Copy link

So whomever wants to look into this, the key here is the server shuts down before the player clicks respawn. that key moment is the issue

@Boomer-1 Boomer-1 added 🧨 Confirmed Bug This bug has been confirmed by our team. and removed 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. labels Feb 21, 2023
@J3fftw1
Copy link
Contributor

J3fftw1 commented Feb 22, 2023

@Boomer-1 i would assume this also happens when the player disconnects and joins back after he died?

@RayBytes
Copy link

ok. i think i figured it out. you're shutting your server down before the player clicks respawn. that's the only way i've been able to do it. so in the extreme possibility that the player dies in that millisecond, and they can't click respawn it disappears. in that brief moment between death and the server restart, the event cant fire. iirc, it fires on the click of respawn. because the data can't be saved thru a restart. not sure if there's a fix to that or not. Dev's will have to look into it.

what about storing it as NBT on the player? in the .dat

@TheBusyBiscuit TheBusyBiscuit changed the title Soulbound items isappear when restarting the server Soulbound items disappear when restarting the server mid-deathscreen Feb 23, 2023
@SrMonsterYT
Copy link

this is also happening on my server, players are reporting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Report A bug that needs to be fixed. 🧨 Confirmed Bug This bug has been confirmed by our team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants