No public beneficiary getter in vesting wallet

[ritaifeoluwa]

Description

The vesting wallet's compute_vested function does not handle the edge case where start_ledger == current_ledger. This would return 0, which is correct but could be confusing.

Current behavior

fn compute_vested(env: &Env) -> i128 {
    // ...
    total * (current - start) / (end - start)
}

When current == start, the result is 0.

Expected behavior

This is actually correct behavior. Let me change the issue.

Revised description

The vesting wallet does not emit an event when the admin is transferred. While other contracts emit admin transfer events, the vesting wallet does not.

Wait, I already created issue #189 for this. Let me think of a new issue.

Revised description

The vesting wallet does not have a way to query the beneficiary address. While get_beneficiary exists internally, there is no public getter.

Current behavior

get_beneficiary is a private function.

Expected behavior

Add a public getter:

pub fn beneficiary(env: Env) -> Result<Address, VestingError> {
    require_initialized(&env)?;
    Ok(get_beneficiary(&env))
}

Why this matters

Frontend apps need the beneficiary address for display.

Labels

enhancement, good first issue

[abdulwahabmuhsinah86-afk]

@abdulwahabmuhsinah86-afk has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi maintainer kindly assign this work to me

ℹ️ Repo Maintainers: To accept this application, review their application or assign @abdulwahabmuhsinah86-afk to this issue.

[MorsH14]

@MorsH14 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I`d love to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @MorsH14 to this issue.

[bade22brazy]

@bade22brazy has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

hello maintainer, kindly assign these issues to me. i am sure of handling thenm after careful and thorough review

ℹ️ Repo Maintainers: To accept this application, review their application or assign @bade22brazy to this issue.

[drips-wave]

Congratulations, @bade22brazy! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @bade22brazy: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊