`acceptEndorsement` does not return true

[akshayarora2009]

On branch develop, in file SmartIdentity.sol, line 218, the function acceptEndorsement does not return true after the endorsement for an attribute is accepted.

Here is the code for reference:

/**
     * Owner can mark an endorsement as accepted.
     */
    function acceptEndorsement(bytes32 _attributeHash, bytes32 _endorsementHash) onlyBy(owner) returns(bool) {
        var attribute = attributes[_attributeHash];
        var endorsement = attribute.endorsements[_endorsementHash];
        endorsement.accepted = true;
        sendEvent(SIG_CHANGE_EVENT, "Endorsement has been accepted");
}

Is that deliberate?

[dci-aloughran]

Thanks for submitting the issue. Please can you add some tests to wrap the new behaviour, then once you've accepted the contributor's agreement, I can merge the PR.

[akshayarora2009]

Hi @dci-aloughran Thanks for your reply. Looks like the Contributor License Agreement is a modified version of the Apache CCLA, which has been applied to individuals as well. I need to inform that I am making this contribution in my individual capacity, and do not represent my employer in any form whatsoever.

I have a query: If I agree to the Contributor's License Agreement, will my employer bind to it in any form?