Skip to content

Commit 9e38bbf

Browse files
committed
Use constant-time array comparison
1 parent 07ac223 commit 9e38bbf

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/main/java/com/smartmovesystems/hashcheck/FirebaseScrypt.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import java.nio.charset.StandardCharsets;
1111
import java.security.GeneralSecurityException;
1212
import java.security.Key;
13-
import java.util.Arrays;
13+
import java.security.MessageDigest;
1414
import java.util.logging.Level;
1515
import java.util.logging.Logger;
1616

@@ -71,7 +71,7 @@ public static boolean check(String passwd, String knownCipherText, String salt,
7171

7272
byte[] knownCipherTextBytes = Base64.decodeBase64(knownCipherText.getBytes(CHARSET));
7373

74-
return Arrays.equals(knownCipherTextBytes, cipherTextBytes);
74+
return MessageDigest.isEqual(knownCipherTextBytes, cipherTextBytes);
7575
}
7676

7777
private static Key generateKeyFromString(byte[] keyVal) {

0 commit comments

Comments
 (0)