feat: add Glossary Entry suggestion status #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreyfurdylo
requested review from
AlexArcher and
bloy-smartling
as code owners
andreyfurdylo
requested review from
PavloMyrotiuk,
Copilot,
rsukharnyk-smartling and
spivenko
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new suggestionStatus field to glossary entries, allowing tracking of whether entries are "SUGGESTED" or "APPROVED". This enhancement supports the workflow for managing glossary entry suggestions in the Smartling platform.
- Added
suggestionStatusfield to theGlossaryEntryBaseResponsePTOclass - Updated test data to include the new field in JSON response
- Added test assertion to verify the field is properly parsed
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| GlossaryEntryBaseResponsePTO.java | Added suggestionStatus field with documentation |
| EntryManagementApiTest.java | Updated test data and assertions to include suggestionStatus field |
...-api/src/main/java/com/smartling/api/glossary/v3/pto/entry/GlossaryEntryBaseResponsePTO.java
Show resolved
Hide resolved
spivenko
approved these changes
Jul 29, 2025
PavloMyrotiuk
approved these changes
Jul 29, 2025
AlexArcher
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this text with a description of your proposed change.
JOBS-8469
Add Glossary Entry suggestion status
Squash Commit Guidelines
This is a reminder on how to format your sqaush commit message. Delete from your PR after noting below.
Message Header
The message header is a single line that contains succinct description of the change containing a type: subject. For example:
feat: add Foo APIAllowed Types
This describes the kind of change that this commit is providing:
Subject Text
This is a very short description of the change.