Failed build when running with coverage on stable Rust #717
Comments
Lurk
added a commit
to Lurk/clink
that referenced
this issue
May 15, 2024
Lurk
added a commit
to Lurk/clink
that referenced
this issue
May 15, 2024
* find_and_replace refactoring * add condition before adding query params * use String instead of Rc<str> * remove unnecessary to_string conversions * use iterators with strings to simplify the logic * packages update * version bump * try to gather coverage on nightly due to Smithay/wayland-rs#717
|
I would also like to see this implemented. |
twvd
added a commit
to twvd/snow
that referenced
this issue
Jan 5, 2025
twvd
added a commit
to twvd/snow
that referenced
this issue
Jan 5, 2025
|
Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Both
wayland-backendandwayland-clienthave a line like the following:wayland-rs/wayland-backend/src/lib.rs
Line 46 in 1fc7814
This is a problem because if building a project with coverage will always try to enable this feature, which will fail if using a stable rustc. This should be changed so the
coverage_attributefeature andcoverage(...)attributes to go with it are not enabled unless compiled with nightly.I think the easiest fix is probably to add a Cargo feature gate for nightly features and use it in place of
#[cfg_attr(coverage, coverage(...))], as well as updating the spots where the feature is enabled.The text was updated successfully, but these errors were encountered: