Skip to content

Commit 71b32c4

Browse files
committed
Keep patch uuids out of bundled-copy diagnostics
CodeQL flagged the new bun and vlt bundled-copy diagnostics for printing the patch uuid. They now name only the package, matching the other recent VEX diagnostics. Assisted-by: Claude Code:claude-opus-5-5
1 parent 98991c2 commit 71b32c4

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

‎crates/socket-patch-core/src/vex/discover/bun.rs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -192,11 +192,11 @@ impl Bundled {
192192
DIAG_REF_UNATTRIBUTABLE,
193193
file,
194194
format!(
195-
"{file}: {label}: {} is wired to Socket patch {}, but bun installs this \
195+
"{file}: {label}: {} is wired to a Socket patch, but bun installs this \
196196
entry as a bundled dependency, unpacked from the parent package's \
197197
tarball that no rewire reaches, so that copy stays unpatched; the patch \
198198
is not attested",
199-
r.purl, r.uuid,
199+
r.purl,
200200
),
201201
);
202202
purls.push(r.purl);
@@ -229,12 +229,12 @@ impl Bundled {
229229
DIAG_REF_UNATTRIBUTABLE,
230230
file,
231231
format!(
232-
"{file}: {} is wired to Socket patch {} but {file} also installs a bundled \
232+
"{file}: {} is wired to a Socket patch but {file} also installs a bundled \
233233
copy of it at {label:?} (bun unpacks bundled dependencies from the parent \
234234
package's tarball, so no rewire reaches it and that copy stays unpatched); \
235235
the patch is not attested while the build ships unpatched bytes of this \
236236
version",
237-
r.purl, r.uuid,
237+
r.purl,
238238
),
239239
);
240240
}

‎crates/socket-patch-core/src/vex/discover/vlt.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -267,12 +267,12 @@ async fn contest_bundled_copies(ctx: &DiscoverCtx<'_>, nodes: &[VltLockNode], ou
267267
DIAG_REF_UNATTRIBUTABLE,
268268
VLT_LOCK,
269269
format!(
270-
"{VLT_LOCK}: {} is wired to Socket patch {} but vlt also installs a bundled \
270+
"{VLT_LOCK}: {} is wired to a Socket patch but vlt also installs a bundled \
271271
copy of it at {location:?} (vlt unpacks bundled dependencies from the parent \
272272
package's tarball and records no lock node for them, so no rewire reaches it \
273273
and that copy stays unpatched); the patch is not attested while the build \
274274
ships unpatched bytes of this version",
275-
r.purl, r.uuid,
275+
r.purl,
276276
),
277277
);
278278
}

0 commit comments

Comments
 (0)