diff --git a/src/ConnectedMode/Migration/RoslynProjectProvider.cs b/src/ConnectedMode/Migration/RoslynProjectProvider.cs index 53e1a61ef7..ddccad29cc 100644 --- a/src/ConnectedMode/Migration/RoslynProjectProvider.cs +++ b/src/ConnectedMode/Migration/RoslynProjectProvider.cs @@ -58,7 +58,7 @@ public IReadOnlyList Get() return new List(); } - return wrappedWorkspace?.CurrentSolution?.Projects.ToList(); + return wrappedWorkspace.CurrentSolution.Projects.ToList(); } } } diff --git a/src/ConnectedMode/Persistence/SolutionBindingRepository.cs b/src/ConnectedMode/Persistence/SolutionBindingRepository.cs index ef14bc2f12..073a673a4e 100644 --- a/src/ConnectedMode/Persistence/SolutionBindingRepository.cs +++ b/src/ConnectedMode/Persistence/SolutionBindingRepository.cs @@ -47,7 +47,7 @@ BoundSonarQubeProject ILegacySolutionBindingRepository.Read(string configFilePat return bindingJsonModel switch { null => null, - not null => bindingJsonModelConverter.ConvertFromModelToLegacy(bindingJsonModel, credentialsLoader.Load(bindingJsonModel.ServerUri)) + _ => bindingJsonModelConverter.ConvertFromModelToLegacy(bindingJsonModel, credentialsLoader.Load(bindingJsonModel.ServerUri)) }; } diff --git a/src/Core/FileMonitor/SingleFileMonitor.cs b/src/Core/FileMonitor/SingleFileMonitor.cs index 3203bdc4b6..937839aa81 100644 --- a/src/Core/FileMonitor/SingleFileMonitor.cs +++ b/src/Core/FileMonitor/SingleFileMonitor.cs @@ -135,7 +135,6 @@ private void CleanUpEmptyDirectory() private void OnFileChanged(object sender, FileSystemEventArgs args) { - Debug.Assert(fileChangedHandlers != null, "Not expecting file system events to be monitored if there are no listeners"); if (fileChangedHandlers == null || disposedValue) { return; diff --git a/src/Integration/Helpers/OutputWindowService.cs b/src/Integration/Helpers/OutputWindowService.cs index 0ef63fd6f4..4ecd7d5193 100644 --- a/src/Integration/Helpers/OutputWindowService.cs +++ b/src/Integration/Helpers/OutputWindowService.cs @@ -45,7 +45,6 @@ public OutputWindowService([Import(typeof(SVsServiceProvider))] IServiceProvider public void Show() { var sonarLintOutputPane = VsShellUtils.GetOrCreateSonarLintOutputPane(serviceProvider); - Debug.Assert(sonarLintOutputPane != null, "Failed to create SonarLint pane"); if (sonarLintOutputPane == null) { diff --git a/src/IssueViz/IssueVisualizationControl/ViewModels/Commands/NavigateToRuleDescriptionCommand.cs b/src/IssueViz/IssueVisualizationControl/ViewModels/Commands/NavigateToRuleDescriptionCommand.cs index e2edb03550..5885e4c6f8 100644 --- a/src/IssueViz/IssueVisualizationControl/ViewModels/Commands/NavigateToRuleDescriptionCommand.cs +++ b/src/IssueViz/IssueVisualizationControl/ViewModels/Commands/NavigateToRuleDescriptionCommand.cs @@ -83,7 +83,7 @@ public object[] ConvertBack( CultureInfo culture) { Debug.Fail("We should not hit here"); - return null; + return Array.Empty(); } } }