Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unload plugin does not reset ActionController callbacks (e.g. after_action) #10

Open
joshbuker opened this issue May 12, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@joshbuker
Copy link
Member

Please complete all sections; bug reports that cannot be reproduced will likely
be closed.

Describe the bug
When using unload_plugin to remove a plugin that has ActionController callbacks, the callbacks are not properly reset.

To Reproduce
Steps to reproduce the behavior:

  1. Inside of ApplicationController:
authenticates_with_sorcery! do |config|
  config.load_plugin(:activity_logging)
end
  1. Inside of a child controller (e.g. AdminSessionsController < ApplicationController)
authenticates_with_sorcery! do |config|
  config.unload_plugin(:activity_logging)
end

Expected behavior
Plugin callbacks do not get ran in controllers that unload the plugin.

@joshbuker joshbuker added the bug Something isn't working label May 12, 2021
@joshbuker joshbuker self-assigned this May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant