Skip to content

Migrate test and docs extras to PEP 735 dependency groups#408

Merged
chrishalcrow merged 5 commits into
SpikeInterface:mainfrom
h-mayorquin:add_pep_735_dependency_groups
Mar 19, 2026
Merged

Migrate test and docs extras to PEP 735 dependency groups#408
chrishalcrow merged 5 commits into
SpikeInterface:mainfrom
h-mayorquin:add_pep_735_dependency_groups

Conversation

@h-mayorquin

Copy link
Copy Markdown
Collaborator

This PR migrates the test and docs development dependencies to be conformant to PEP 735 by moving them from [project.optional-dependencies] to [dependency-groups]. The advantage is that dependency groups are not packed into the distribution for most users and are better handled by package managers like uv.

@alejoe91

Copy link
Copy Markdown
Member

I think we need to update the .readthedocs.yaml too

@h-mayorquin

Copy link
Copy Markdown
Collaborator Author

I think we need to update the .readthedocs.yaml too

Done.

@h-mayorquin

Copy link
Copy Markdown
Collaborator Author

I also added dev with everything that is needed.

@chrishalcrow

Copy link
Copy Markdown
Member

I'm getting issues with python >= 3.12 and matplotlib < 3.5:

      AttributeError: module 'configparser' has no attribute
      'SafeConfigParser'.

Tried taking the restriction off of matplotlib in docs locally and everything built ok - can we do that here and see if the CI runs ok?

@h-mayorquin

Copy link
Copy Markdown
Collaborator Author

I'm getting issues with python >= 3.12 and matplotlib < 3.5:

      AttributeError: module 'configparser' has no attribute
      'SafeConfigParser'.

Tried taking the restriction off of matplotlib in docs locally and everything built ok - can we do that here and see if the CI runs ok?

Yes, let's try.

@chrishalcrow chrishalcrow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look fine with newer matplotlib

@chrishalcrow chrishalcrow merged commit 208a95b into SpikeInterface:main Mar 19, 2026
9 checks passed
@h-mayorquin h-mayorquin deleted the add_pep_735_dependency_groups branch March 20, 2026 00:19
@h-mayorquin

Copy link
Copy Markdown
Collaborator Author

Thanks for the review @chrishalcrow

@samuelgarcia

Copy link
Copy Markdown
Member

geneial

I was not aware of the {include-group = "test"} syntax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants