Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kali patches should have a clear diff with only code removal #151

Open
monperrus opened this issue Feb 14, 2018 · 3 comments
Open

Kali patches should have a clear diff with only code removal #151

monperrus opened this issue Feb 14, 2018 · 3 comments

Comments

@monperrus
Copy link
Contributor

when angelic value and observed value are all false

@tdurieux
Copy link
Contributor

why?

@monperrus
Copy link
Contributor Author

monperrus commented Feb 16, 2018

because we spend a lot of time to understand that the Dynamoth condition always evaluates to false.

Let me rephrase:

  • we don't want any synthesis for Kali patch, in particular the Dynamoth synthesis that yields many of them
  • we want Kali-like patches to be output as a diff with only deletion.

@monperrus monperrus changed the title nopol should not generate a Kali patch that only removes code Kali patches should have a clear diff with only code removal Mar 4, 2018
@monperrus
Copy link
Contributor Author

if patch is if (true) then diff should contain the else block removed.

if patch is if (false) then diff should contain the if block removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants