Merge pull request #50 from SpringRoll/bugfix/remove-method-override

Bugfix/remove method override

Author: chipbell4

app/routes/index.js

@@ -3,7 +3,6 @@ module.exports = function(app)
 	const access = require('../helpers/access');
 	const marky = require("marky-markdown");
 	const Config = require('../models/config');
-	const methodOverride = require('method-override');
 
 	// Add the user to whatever template
 	app.use(function(req, res, next)
@@ -38,17 +37,23 @@ module.exports = function(app)
 		});
 	});
 
-	app.use(methodOverride(function (req, res) {
+	app.use(function (req, res, next) {
 		const route = req.originalUrl.startsWith('/games') || req.originalUrl.startsWith('/archive') || req.originalUrl.startsWith('/releases');
 		const contents = req.body && typeof req.body === 'object' && 'action' in req.body;
+		// if fails cases, can just pass through w/ no change
 		if (route && contents) {
+			// Map RESTORE keyword to PATCH action, w/ isArchived flag change
 			if (req.body.action === 'RESTORE') {
 				req.body.isArchived = false;
-				return 'PATCH';
+				req.method = 'PATCH';
+			}
+			// Set POST to PATCH / DELETE based on value in form
+			else {
+				req.method = req.body.action;
 			}
-			return req.body.action;
 		}
-	}));
+		next();
+	});
 
 	// Site pages
 	app.use('/', require('./home'));

app/views/games/releases.jade

@@ -81,7 +81,7 @@ append gameContent
 											a(href="#{game.repository}/browse?at=refs/heads/#{release.branch.replace('origin/', '')}" data-toggle="tooltip" title="View Branch")=' '+release.branch
 
 								.help-block.updated
-									span Updated
+									span Updated  
 									span=moment(release.updated).fromNow()
 									if release.updatedBy
 										|  by #{release.updatedBy.name}

npm-shrinkwrap.json

@@ -29,7 +29,6 @@
     "jade": "^1.9.2",
     "jquery": "^3.0.0",
     "marky-markdown": "^12.0.0",
-    "method-override": "3.0.0",
     "moment": "^2.9.0",
     "mongoose": "~4.0.4",
     "mongoose-deep-populate": "^1.0.1",