Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using milliCPU notation for resource requests rather than integer string #393

Open
inviscid opened this issue Jan 11, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@inviscid
Copy link

Describe the current behavior

Currently, resource requests are required to be integer strings. Attempting to use milliCPU notation fails.

This works:

starrocks:
  cn:
    cpu: '1'
    memory: 4Gi
    replicas: 1
  fe:
    cpu: '1'
    memory: 4Gi
    replicas: 3

This does not:

starrocks:
  cn:
    cpu: 500m
    memory: 4Gi
    replicas: 1
  fe:
    cpu: 500m
    memory: 4Gi
    replicas: 3

Describe the enhancement

Allow use of milliCPU notation and pass through to the underlying statefulset and pod resource requests as specified.

Additional context

N/A

@inviscid inviscid added the enhancement New feature or request label Jan 11, 2024
@yandongxiao
Copy link
Collaborator

Operator has supported milliCPU from the beginning. What version is your Operator, and what error did it report?
This is from StarRocksCluster CR.

    limits:
      cpu: 2
      memory: 4Gi
    requests:
      cpu: 100m
      memory: 200Mi

@yandongxiao
Copy link
Collaborator

‌‌I believe the operator has already supported this requirement. I will now close this issue. If your problem has not been resolved, please reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants