Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in starrocks-3.1.15, I changed WITH_STARCACHE to OFF in build.sh, and the compilation still depends on starcache! #51220

Open
loong-hy opened this issue Sep 20, 2024 · 5 comments
Labels
type/bug Something isn't working

Comments

@loong-hy
Copy link

loong-hy commented Sep 20, 2024

in starrocks-3.1.15, I changed WITH_STARCACHE to OFF in build.sh, and the compilation still depends on starcache!

if [[ -z ${WITH_STARCACHE} ]]; then WITH_STARCACHE=OFF fi

I've already seen WITH_STARCACHE set to OFF via ccmake,But the compilation still reports a missing starcache header file error.

`
[ 1%] Building CXX object src/agent/CMakeFiles/Agent.dir/task_worker_pool.cpp.o
In file included from /home/beckhuang/workspace/starrocks-3.1.15/be/src/block_cache/block_cache.h:17,
from /home/beckhuang/workspace/starrocks-3.1.15/be/src/common/daemon.cpp:39:
/home/beckhuang/workspace/starrocks-3.1.15/be/src/block_cache/kv_cache.h:20:10: fatal error: starcache/star_cache.h: No such file or directory
20 | #include "starcache/star_cache.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [src/common/CMakeFiles/Common.dir/build.make:76:src/common/CMakeFiles/Common.dir/daemon.cpp.o] 错误 1

`

@loong-hy loong-hy added the type/bug Something isn't working label Sep 20, 2024
@kevincai
Copy link
Contributor

@GavinMar do we support to turn off star cache completely on branch-3.1?

@rohitrs1983
Copy link
Contributor

@GavinMardo we support to turn off star cache completely on branch-3.1?

@kevincai #40599
not present in 3.1.15 branch

@loong-hy
Copy link
Author

@GavinMardo we support to turn off star cache completely on branch-3.1?

@kevincai #40599 not present in 3.1.15 branch

您好,有回合到3.1分支的计划么?

@kevincai
Copy link
Contributor

@loong-hy not right now, can you manually cherry-pick the corresponding PR for your compilation on branch-3.1?

@loong-hy
Copy link
Author

@loong-hy not right now, can you manually cherry-pick the corresponding PR for your compilation on branch-3.1?

Okay, I'll try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants