[BugFix] Reset schema id when restore #51230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why I'm doing: currently, restore do not reset schema id. If the id is conflict with one existed schema which has the same id, restore process will get wrong schema info from the schema cache and restore will be failed. What I'm doing: Reset schema id when restore Signed-off-by: srlch <[email protected]>
srlch
force-pushed
the
bugfix_restore_reset_schema_id
branch
from
8f2fec9
to
cb640b2
Compare
wyb
reviewed
Sep 20, 2024
fe/fe-core/src/main/java/com/starrocks/catalog/MaterializedIndexMeta.java
Outdated
Show resolved
Hide resolved
Signed-off-by: srlch <[email protected]>
|
wyb
approved these changes
Sep 20, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
sevev
approved these changes
Sep 23, 2024
gengjun-git
approved these changes
Sep 23, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
## Why I'm doing: currently, restore do not reset schema id. If the id is conflict with one existed schema which has the same id, restore process will get wrong schema info from the schema cache and restore will be failed. ## What I'm doing: Reset schema id when restore Signed-off-by: srlch <[email protected]> (cherry picked from commit 6996728)
mergify bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
## Why I'm doing: currently, restore do not reset schema id. If the id is conflict with one existed schema which has the same id, restore process will get wrong schema info from the schema cache and restore will be failed. ## What I'm doing: Reset schema id when restore Signed-off-by: srlch <[email protected]> (cherry picked from commit 6996728)
This was referenced Sep 23, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 23, 2024
Co-authored-by: srlch <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 23, 2024
Co-authored-by: srlch <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
## Why I'm doing: currently, restore do not reset schema id. If the id is conflict with one existed schema which has the same id, restore process will get wrong schema info from the schema cache and restore will be failed. ## What I'm doing: Reset schema id when restore Signed-off-by: srlch <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
currently, restore do not reset schema id. If the id is conflict with one existed schema which has the same id, restore process will get wrong schema info from the schema cache and restore will be failed.
What I'm doing:
Reset schema id when restore
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: