[Enhancement] Set cookie path & http_only to make it more safe #51242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Satardekar <[email protected]>
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 2 / 2 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
kevincai
approved these changes
Sep 21, 2024
alvin-celerdata
approved these changes
Sep 23, 2024
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
Why I'm doing: Using the HttpOnly flag when generating a cookie helps mitigate the risk of client side script accessing the protected cookie. What I'm doing: Set cookie path & http_only to make it more safe Fixes #51241 Signed-off-by: Rohit Satardekar <[email protected]> (cherry picked from commit be34948)
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 23, 2024
…ort #51242) (#51249) Co-authored-by: Rohit Satardekar <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…ocks#51242) Why I'm doing: Using the HttpOnly flag when generating a cookie helps mitigate the risk of client side script accessing the protected cookie. What I'm doing: Set cookie path & http_only to make it more safe Fixes StarRocks#51241 Signed-off-by: Rohit Satardekar <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Using the HttpOnly flag when generating a cookie helps mitigate the risk of client side script accessing the protected cookie.
What I'm doing:
Set cookie path & http_only to make it more safe
Fixes #51241
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: