Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addon catalog (CatalogFiltered): no installed addons #102

Closed
Ivshti opened this issue Sep 14, 2019 · 1 comment
Closed

addon catalog (CatalogFiltered): no installed addons #102

Ivshti opened this issue Sep 14, 2019 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@Ivshti
Copy link
Member

Ivshti commented Sep 14, 2019

Using CatalogFiltered and addonCatalogs for addons is great, but it has a flaw: there are no installed addons in the catalog

this can be solved:

  • at a UI level, add another route /installed which just displays ctx.content.addons with some filtering
  • by wrapping CatalogFiltered and adding installed by splitting the Load action into Installed(type) or Catalog(resource_ref); this has two extra advantages:
    • allows to structure the navigation conveniently at a model level (we can choose between catalog -> type or type -> catalog)
    • different Load action for addons; otherwise we have to wire msgs in the app in such a way that only model.discover or only model.addons will receive a certain Load
    • we can also implement addon search, see in-memory search for various models #93
  • by creating a fake addon
@Ivshti Ivshti added bug Something isn't working enhancement New feature or request labels Sep 14, 2019
@Ivshti Ivshti added this to the v1.0 milestone Sep 14, 2019
@nklhtv
Copy link
Contributor

nklhtv commented Feb 24, 2020

its done on the UI level before core

@nklhtv nklhtv closed this as completed Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants