Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player model: save stream ID (hash) #65

Open
Ivshti opened this issue Jun 9, 2019 · 1 comment
Open

Player model: save stream ID (hash) #65

Ivshti opened this issue Jun 9, 2019 · 1 comment
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@Ivshti
Copy link
Member

Ivshti commented Jun 9, 2019

save the hash (or prefix of hash) of the last playing stream in the LibItem, in order to be able to identify it on another device as well

@Ivshti Ivshti added this to the v1.0 milestone Jul 28, 2019
@Ivshti Ivshti changed the title LibAddon: save stream ID (hash) Player model: save stream ID (hash) Jan 3, 2020
@nklhtv nklhtv self-assigned this Jan 7, 2020
@nklhtv
Copy link
Contributor

nklhtv commented Jun 8, 2022

Should be implemented as a StreamsBucket, which should behave and be structured in a similar way as LibraryBucket.

We could also persist the entire stream object and not just a hash against which we match later.

Possible structure of the StreamsBucket could be:

#[serde_as]
#[derive(Serialize, Deserialize)]
struct StreamsBucket {
    pub uid: UID,
    #[serde_as(as = "Vec<(_, _)>")]
    pub items: HashMap<(String, String), (Url, Stream)>,
}

where the key is (item.id, video.id) and the value is (addon.transport_url, stream)

  • last_modified could also be added so we do not persist too old streams

@nklhtv nklhtv added the good first issue Good for newcomers label Jun 8, 2022
elpiel added a commit that referenced this issue Jun 14, 2024
feat: add dev build and skip package.json creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants