Discover: Remove duplicated filters in filter modal #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Botsy
changed the title
Botsy
changed the title
Botsy
commented
Feb 21, 2025
Comment on lines
-13
to
-22
| const Multiselect = ({ className, mode, direction, title, disabled, dataset, renderLabelContent, renderLabelText, onOpen, onClose, onSelect, ...props }) => { | ||
| const Multiselect = ({ className, mode, direction, title, disabled, dataset, options, renderLabelContent, renderLabelText, onOpen, onClose, onSelect, ...props }) => { | ||
| const [menuOpen, , closeMenu, toggleMenu] = useBinaryState(false); | ||
| const options = React.useMemo(() => { | ||
| return Array.isArray(props.options) ? | ||
| props.options.filter((option) => { | ||
| const filteredOptions = React.useMemo(() => { | ||
| return Array.isArray(options) ? | ||
| options.filter((option) => { | ||
| return option && (typeof option.value === 'string' || option.value === null); | ||
| }) | ||
| : | ||
| []; | ||
| }, [props.options]); |
There was a problem hiding this comment.
I destructured the options from the props because they were being unnecessarily rendered in the html as props in the elements.
kKaskak
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix for Discover page shows in the filters modal only the filters that are not visible as a dropdown above the results. Also fixes the spacing issue of the filter button on larger screens with more than 3 filters.