Fixes for 'ds.colnames'

Author: StuartWheater

tests/testthat/perf_files/default_perf_profile.csv

@@ -6,7 +6,7 @@
 "ds.asNumeric::perf:0","2.185","0.5","2"
 "ds.assign::perf::0","5.490","0.5","2"
 "ds.class::perf::combine:0","4.760","0.5","2"
-"ds.colnames::perf:0","4.159","0.5","2"
+"ds.colnames::perf:0","9.578","0.5","2"
 "ds.exists::perf::combine:0","11.09","0.5","2"
 "ds.length::perf::combine:0","9.479","0.5","2"
 "ds.mean::perf::combine:0","9.650","0.5","2"

tests/testthat/test-smk-ds.colnames.R

@@ -47,18 +47,21 @@ test_that("simple colnames", {
 test_that("fails if the object does not exist", {
   expect_error(
     ds.colnames("non_existing_df"),
-    regexp = "'non_existing_df' does not exist",
+    regexp = "There are some DataSHIELD errors, list them with datashield.error()",
     ignore.case = TRUE
   )
 })
 
-test_that("fails if object is not a data frame or matrix", {
-  expect_error(
-    ds.colnames("D$LAB_TSC"),
-    regexp = "must be of type data.frame or matrix",
-    ignore.case = TRUE
-  )
-})
+###########################################
+###     Remote checks not performed     ###
+###########################################
+# test_that("fails if object is not a data frame or matrix", {
+#   expect_error(
+#     ds.colnames("D$LAB_TSC"),
+#     regexp = "must be of type data.frame or matrix",
+#     ignore.case = TRUE
+#   )
+# })
 
 #
 # Done