Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor-Syntax #161

Open
keith-hall opened this issue Jul 23, 2018 · 6 comments
Open

Editor-Syntax #161

keith-hall opened this issue Jul 23, 2018 · 6 comments

Comments

@keith-hall
Copy link
Member

Hi,

I believe that the Editor-Syntax repository has had a few bug fixes upstream since it was copied for use in this repo. Would it make sense to have it as a git submodule, to make it easier to see which version is currently being used by this package, and easier to update this package to use the latest version?

@vors
Copy link
Member

vors commented Jul 28, 2018

ST package manager currently uses master for install. Can it work with submodules? If so, we should do that.

@keith-hall
Copy link
Member Author

Good question - Package Control just uses GitHub's zip download feature, so I guess it depends whether submodules are included in the zip or not. I will try to investigate this, thanks.

@vors
Copy link
Member

vors commented Jul 28, 2018

Thank you, Keith, for taking a look at it. I was too lazy to investigate it properly. If it turns out that it doesn't, we can include a file with a commit sha and a script to auto-update it, something like that.

@keith-hall
Copy link
Member Author

keith-hall commented Jul 29, 2018

I have tested, and GitHub doesn't include submodules in the zip file. Your auto update script idea sounds like a good one.

@michaelblyons
Copy link
Collaborator

Could you (hard|soft|sym)link to the file that lives in the submodule such that GitHub adds it to the zip? And make a script to convert the file (if Git thinks the link is a file) into a link to be run after clone?

@vors
Copy link
Member

vors commented Apr 21, 2019

Not sure is it possible or not. Currently there is no submodule because I don't know how sublime packages with submodules work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants