Skip to content

Commit f3d2b60

Browse files
committed
Fix blockers reported by SonarCloud
1 parent 12bf1d9 commit f3d2b60

File tree

5 files changed

+15
-3
lines changed

5 files changed

+15
-3
lines changed

src/main/java/eu/happycoders/sort/method/bubblesort/BubbleSortParallel.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import eu.happycoders.sort.method.Counters;
44
import eu.happycoders.sort.method.SortAlgorithm;
5+
import eu.happycoders.sort.utils.NotImplementedException;
56
import java.util.concurrent.Phaser;
67
import java.util.concurrent.atomic.AtomicInteger;
78

@@ -97,6 +98,6 @@ private int[] partition(int[] elements) {
9798

9899
@Override
99100
public void sort(int[] elements, Counters counters) {
100-
// Not implemented
101+
throw new NotImplementedException();
101102
}
102103
}

src/main/java/eu/happycoders/sort/method/heapsort/BottomUpHeapsortSlowComparisons.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package eu.happycoders.sort.method.heapsort;
22

33
import eu.happycoders.sort.method.Counters;
4+
import eu.happycoders.sort.utils.NotImplementedException;
45

56
public class BottomUpHeapsortSlowComparisons extends BottomUpHeapsort {
67

@@ -41,7 +42,7 @@ int findTargetNodeBottomUp(int[] heap, int rootPos, int leafPos) {
4142

4243
@Override
4344
public void sort(int[] elements, Counters counters) {
44-
throw new Error("Not implemented");
45+
throw new NotImplementedException();
4546
}
4647

4748
private void slowDown() {

src/main/java/eu/happycoders/sort/method/heapsort/HeapsortSlowComparisons.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import eu.happycoders.sort.method.Counters;
44
import eu.happycoders.sort.utils.ArrayUtils;
5+
import eu.happycoders.sort.utils.NotImplementedException;
56

67
public class HeapsortSlowComparisons extends Heapsort {
78

@@ -48,7 +49,7 @@ void heapify(int[] heap, int length, int parentPos) {
4849

4950
@Override
5051
public void sort(int[] elements, Counters counters) {
51-
throw new Error("Not implemented");
52+
throw new NotImplementedException();
5253
}
5354

5455
private void slowDown() {
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
package eu.happycoders.sort.utils;
2+
3+
/**
4+
* An exception to be thrown from a not implemented method.
5+
*
6+
* @author <a href="[email protected]">Sven Woltmann</a>
7+
*/
8+
public class NotImplementedException extends RuntimeException {}

src/test/java/eu/happycoders/sort/method/countingsort/CountingSortTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import eu.happycoders.sort.utils.ArrayUtils;
66
import org.junit.jupiter.api.RepeatedTest;
77

8+
@SuppressWarnings("java:S2699") // The assertions are in the sortAndTestIfSorted() method
89
public class CountingSortTest extends SortTest {
910

1011
@RepeatedTest(100)

0 commit comments

Comments
 (0)