test: fix deal precondition failure in IT (#3367)

Author: Panaetius

renku/core/migration/utils/conversion.py

@@ -21,6 +21,7 @@
 from urllib.parse import urlparse
 
 from renku.core.migration.models import v9 as old_datasets
+from renku.core.util.datetime8601 import fix_datetime
 from renku.core.util.git import get_entity_from_revision
 from renku.core.util.urls import get_slug
 from renku.domain_model.dataset import (
@@ -192,10 +193,10 @@ def convert_license(license):
         Dataset(
             creators=[_convert_agent(creator) for creator in dataset.creators],
             dataset_files=convert_dataset_files(dataset.files),
-            date_created=dataset.date_created,
-            date_published=dataset.date_published,
+            date_created=fix_datetime(dataset.date_created),
+            date_published=fix_datetime(dataset.date_published),
             date_removed=None,
-            date_modified=dataset.date_created or dataset.date_published,
+            date_modified=fix_datetime(dataset.date_created or dataset.date_published),
             derived_from=convert_derived_from(dataset.derived_from, dataset.same_as),
             description=dataset.description,
             id=id,

renku/domain_model/dataset.py

@@ -550,8 +550,8 @@ def replace_identifier(self, identifier: Optional[str] = None):
         or (self.date_created is None and self.date_published is not None)
     )
     @deal.ensure(
-        lambda self, *_, result, **kwargs: self.date_modified >= self.date_created
-        or self.date_modified >= self.date_published
+        lambda self, *_, result, **kwargs: (self.date_created is not None and self.date_modified >= self.date_created)
+        or (self.date_published is not None and self.date_modified >= self.date_published)
     )
     @deal.ensure(lambda self, *_, result, **kwargs: self.derived_from is not None)
     def derive_from(

renku/infrastructure/gateway/dataset_gateway.py

@@ -71,12 +71,10 @@ def remove_tag(self, dataset: Dataset, tag: DatasetTag):
                 tags.remove(t)
                 break
 
-    @deal.pre(
-        lambda _: _.dataset.date_created is None or _.dataset.date_created >= project_context.project.date_created
-    )
-    @deal.pre(
-        lambda _: _.dataset.date_published is None or _.dataset.date_published >= project_context.project.date_created
-    )
+    # NOTE: Enable this again once we properly deal with `date_created` on imported Renku datasets
+    # @deal.pre(
+    #     lambda _: _.dataset.date_created is None or _.dataset.date_created >= project_context.project.date_created
+    # )
     def add_or_remove(self, dataset: Dataset) -> None:
         """Add or remove a dataset."""
         database = project_context.database