Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade wgpu to 22.0 #37

Closed
songhuaixu opened this issue Jul 24, 2024 · 7 comments
Closed

Upgrade wgpu to 22.0 #37

songhuaixu opened this issue Jul 24, 2024 · 7 comments

Comments

@songhuaixu
Copy link

No description provided.

@Swoorup
Copy link
Owner

Swoorup commented Jul 27, 2024

Currently blocked by: bevyengine/naga_oil#98

@9SMTM6
Copy link

9SMTM6 commented Aug 4, 2024

was fixed yesterday btw, IDK if you monitored these.

@Swoorup
Copy link
Owner

Swoorup commented Aug 4, 2024

was fixed yesterday btw, IDK if you monitored these.

Yup on top of it, I am waiting on the release. However won't be able to get to this until the next weekend, but can accept PRs until then.

This should be quite straightforward compared to the last wgpu/naga_oil release though

@9SMTM6
Copy link

9SMTM6 commented Aug 8, 2024

BTW, the example doesn't compile on stable right now. It sets a feature in include_absolute_path, which also seems to be from you.

That blocked me from trying my hand at this earlier.

I'll just ignore the example and just run the tests in the actual crate.

@9SMTM6
Copy link

9SMTM6 commented Aug 8, 2024

puh. frankly, I'm out of my depth when it comes to upgrading this. With the first real error in cargo check I have no idea how to port this to the newer naga_oil function. That function removed a parameter (ShaderStages from naga), and I dont know where this information should go now. It was removed from the struct altogether. There is no changelist for naga_oil, and and I can't find any example code for how to port, since e.g. bevy-render, the one reverse-dependency out of the bevy project, did not update yet.

@Swoorup
Copy link
Owner

Swoorup commented Aug 9, 2024

BTW, the example doesn't compile on stable right now. It sets a feature in include_absolute_path, which also seems to be from you.

That blocked me from trying my hand at this earlier.

I'll just ignore the example and just run the tests in the actual crate.

You could use other output mode as someone mentioned here #32 (comment), ie UseComposerEmbed to try using the stable compiler.

The include_absolute_path is used to embedded the shader path of the source, which is useful in implementing hotreloading shaders. The example enables all shader source output strategy. You could simply disable UseComposerWithPath option

@Swoorup
Copy link
Owner

Swoorup commented Aug 10, 2024

Fixed in #40
Released: 0.15.0

@Swoorup Swoorup closed this as completed Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants