ProductListViewFactory cannot be extended

[11mb]

Should the ProductListViewFactory be a final class? Now it is very hard to change the creation of e.g. a variantView.

I want to pass the options from VariantDocument:getOptions() to the VariantView via the ProductListViewFactory. But because this class is final, and the getVarantViews method is private I have to duplicate the whole class.

[pamil]

It is meant to be final, even though we should extract more view factories, like ProductViewFactory, ProductVariantViewFactory, so that the interfaces would be more segregated and most of the extensions can be done by composition (just like with the document factories).

[pamil]

Don't know why but I can't assign you @psihius so I'm writing this comment 🎉

[psihius]

Probably because i'm not a member of the organization/repository @pamil :)

[samvdb]

@11mb, Not sure if this can help you, but if you use symfony's service decoration you can inject the ProductListViewFactory into your new service, then simply call the createFromSearchResponse() on the inner service and perform your extra logic on the ProductListView object that is returned.