un-hardcode some TAStudio shortcuts

Specifically: un-hardcode copy, paste, paste insert, cut,
and state history integrity check
fixes #3001

Author: RetroEdit

src/BizHawk.Client.Common/config/Binding.cs

@@ -146,12 +146,17 @@ void Bind(string tabGroup, string displayName, string defaultBinding = "", strin
 			Bind("TAStudio", "Sel. bet. Markers", "Ctrl+A");
 			Bind("TAStudio", "Select All", "Ctrl+Shift+A");
 			Bind("TAStudio", "Reselect Clip.", "Ctrl+B");
+			Bind("TAStudio", "Copy Frames", "Ctrl+C");
+			Bind("TAStudio", "Paste Frames", "Ctrl+V");
+			Bind("TAStudio", "Paste Insert Frames", "Ctrl+Shift+V");
+			Bind("TAStudio", "Cut Frames", "Ctrl+X");
 			Bind("TAStudio", "Clear Frames", "Delete");
 			Bind("TAStudio", "Delete Frames", "Ctrl+Delete");
 			Bind("TAStudio", "Insert Frame", "Insert");
 			Bind("TAStudio", "Insert # Frames", "Shift+Insert");
 			Bind("TAStudio", "Clone Frames", "Ctrl+Insert");
 			Bind("TAStudio", "Clone # Times", "Ctrl+Shift+Insert");
+			Bind("TAStudio", "State Hist. Integrity Check", "Ctrl+Shift+I");
 			Bind("TAStudio", "Analog Increment", "Up");
 			Bind("TAStudio", "Analog Decrement", "Down");
 			Bind("TAStudio", "Analog Incr. by 10", "Shift+Up");

src/BizHawk.Client.EmuHawk/MainForm.Hotkey.cs

@@ -6,6 +6,11 @@ namespace BizHawk.Client.EmuHawk
 {
 	public partial class MainForm
 	{
+		private bool TAStudioFocused()
+		{
+			return Tools.IsLoaded<TAStudio>() && Tools.Get<TAStudio>().ContainsFocus;
+		}
+
 		private bool CheckHotkey(string trigger)
 		{
 			void SelectAndSaveToSlot(int slot)
@@ -77,7 +82,7 @@ void SelectAndLoadFromSlot(int slot)
 				case "Screen Raw to Clipboard":
 					// Ctrl+C clash. any tool that has such acc must check this.
 					// maybe check if mainform has focus instead?
-					if (!(Tools.IsLoaded<TAStudio>() && Tools.Get<TAStudio>().ContainsFocus)) TakeScreenshotToClipboard();
+					if (!TAStudioFocused()) TakeScreenshotToClipboard();
 					break;
 				case "Screen Client to Clipboard":
 					TakeScreenshotClientToClipboard();
@@ -450,6 +455,24 @@ void SelectAndLoadFromSlot(int slot)
 					if (!Tools.IsLoaded<TAStudio>()) return false;
 					Tools.TAStudio.ReselectClipboardExternal();
 					break;
+				case "Copy Frames":
+					// This one at least *needs* to check for TAStudio focus,
+					// specifically to avoid Ctrl+C conflicts
+					if (!TAStudioFocused()) return false;
+					Tools.TAStudio.CopyFramesExternal();
+					break;
+				case "Paste Frames":
+					if (!TAStudioFocused()) return false;
+					Tools.TAStudio.PasteFramesExternal();
+					break;
+				case "Paste Insert Frames":
+					if (!TAStudioFocused()) return false;
+					Tools.TAStudio.PasteInsertFramesExternal();
+					break;
+				case "Cut Frames":
+					if (!TAStudioFocused()) return false;
+					Tools.TAStudio.CutFramesExternal();
+					break;
 				case "Clear Frames":
 					if (!Tools.IsLoaded<TAStudio>()) return false;
 					Tools.TAStudio.ClearFramesExternal();
@@ -474,6 +497,10 @@ void SelectAndLoadFromSlot(int slot)
 					if (!Tools.IsLoaded<TAStudio>()) return false;
 					Tools.TAStudio.CloneFramesXTimesExternal();
 					break;
+				case "State Hist. Integrity Check":
+					if (!TAStudioFocused()) return false;
+					Tools.TAStudio.StateHistoryIntegrityCheckExternal();
+					break;
 				case "Analog Increment":
 					if (!Tools.IsLoaded<TAStudio>()) return false;
 					Tools.TAStudio.AnalogIncrementByOne();

src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.Designer.cs

@@ -226,14 +226,23 @@ public override void HandleHotkeyUpdate()
 			SelectBetweenMarkersMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Sel. bet. Markers"];
 			SelectAllMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Select All"];
 			ReselectClipboardMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Reselect Clip."];
+			CopyMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Copy Frames"];
+			PasteMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Paste Frames"];
+			PasteInsertMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Paste Insert Frames"];
+			CutMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Cut Frames"];
 			ClearFramesMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Clear Frames"];
 			DeleteFramesMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Delete Frames"];
 			InsertFrameMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Insert Frame"];
 			InsertNumFramesMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Insert # Frames"];
 			CloneFramesMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Clone Frames"];
 			CloneFramesXTimesMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Clone # Times"];
+			StateHistoryIntegrityCheckMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["State Hist. Integrity Check"];
 
 			SelectBetweenMarkersContextMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Sel. bet. Markers"];
+			copyToolStripMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Copy Frames"];
+			pasteToolStripMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Paste Frames"];
+			pasteInsertToolStripMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Paste Insert Frames"];
+			cutToolStripMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Cut Frames"];
 			ClearContextMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Clear Frames"];
 			DeleteFramesContextMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Delete Frames"];
 			InsertFrameContextMenuItem.ShortcutKeyDisplayString = Config.HotkeyBindings["Insert Frame"];
@@ -485,6 +494,21 @@ public void AddColumn(string name, string text, int widthUnscaled)
 
 		public void LoadBranchByIndex(int index) => BookMarkControl.LoadBranchExternal(index);
 
+		public void CopyFramesExternal()
+			=> CopyMenuItem_Click(null, EventArgs.Empty);
+
+		public void PasteFramesExternal()
+			=> PasteMenuItem_Click(null, EventArgs.Empty);
+
+		public void PasteInsertFramesExternal()
+			=> PasteInsertMenuItem_Click(null, EventArgs.Empty);
+
+		public void CutFramesExternal()
+			=> CutMenuItem_Click(null, EventArgs.Empty);
+
+		public void StateHistoryIntegrityCheckExternal()
+			=> StateHistoryIntegrityCheckMenuItem_Click(null, EventArgs.Empty);
+
 		public void ClearFramesExternal()
 			=> ClearFramesMenuItem_Click(null, EventArgs.Empty);