Make CA1851 (re: multiple enumerations) stricter

YoshiRulz · YoshiRulz · commit b7b10eb2ad20 · 2025-10-21T22:14:54.000+10:00
fixes 997cc59
diff --git a/.global.editorconfig.ini b/.global.editorconfig.ini
@@ -124,6 +124,7 @@ dotnet_diagnostic.CA1836.severity = error
 dotnet_diagnostic.CA1838.severity = suggestion
 # Possible multiple enumerations of `IEnumerable` collection
 dotnet_diagnostic.CA1851.severity = warning
+dotnet_code_quality.CA1851.assume_method_enumerates_parameters = true
 # Prefer the `IDictionary.TryGetValue(TKey, out TValue)` method
 dotnet_diagnostic.CA1854.severity = warning
 # Avoid using 'Enumerable.Any()' extension method
diff --git a/src/BizHawk.Client.Common/movie/tasproj/TasMovieMarker.cs b/src/BizHawk.Client.Common/movie/tasproj/TasMovieMarker.cs
@@ -183,6 +183,7 @@ public void Add(int frame, string message)
 
 		public new void InsertRange(int index, IEnumerable<TasMovieMarker> collection)
 		{
+			collection = collection as IReadOnlyCollection<TasMovieMarker> ?? collection.ToArray();
 			bool endBatch = _movie.ChangeLog.BeginNewBatch("Add Markers", true);
 			foreach (TasMovieMarker m in collection)
 			{

Original file line number	Diff line number	Diff line change
`@@ -183,6 +183,7 @@ public void Add(int frame, string message)`
`183`	`183`
`184`	`184`	`public new void InsertRange(int index, IEnumerable<TasMovieMarker> collection)`
`185`	`185`	`{`
	`186`	`+ collection = collection as IReadOnlyCollection<TasMovieMarker> ?? collection.ToArray();`
`186`	`187`	`bool endBatch = _movie.ChangeLog.BeginNewBatch("Add Markers", true);`
`187`	`188`	`foreach (TasMovieMarker m in collection)`
`188`	`189`	`{`