[feat/#43]지도 장소 검색 및 경로 목록 뷰 #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooyoung2309
approved these changes
Aug 24, 2023
Comment on lines
14
to
17
| Text("닫기") | ||
| .font(Font.custom("Apple SD Gothic Neo", size: 17)) | ||
| .foregroundColor(Color(red: 1, green: 0.53, blue: 0.53)) | ||
| .padding(.trailing, 16) |
There was a problem hiding this comment.
p3;
font는 이후에 디자인 시스템을 반영해주시면 될것같아요!
Comment on lines
15
to
28
| HStack{ | ||
| Image(systemName: "bus") | ||
| .resizable() | ||
| .frame(width: 20, height: 20) | ||
| .foregroundColor(Color(red: 0.34, green: 0.33, blue: 0.86)) | ||
| .shadow(color: .black.opacity(0.1), radius: 2.5, x: 0, y: 0) | ||
| .padding(.leading, 16) | ||
| Text("잠실나루역") | ||
| .font( | ||
| Font.custom("Apple SD Gothic Neo", size: 13) | ||
| .weight(.bold) | ||
| ) | ||
| .foregroundColor(Color(red: 0.25, green: 0.25, blue: 0.25)) | ||
| Text("24125") |
There was a problem hiding this comment.
p3;
너무 많은 뷰들이 겹쳐있어요. 조금 더 가독성 높게 파일로 분리하거나 함수로 빼거나 구조체로 따로 빼는게 좋아보입니다.
| Font.custom("Apple SD Gothic Neo", size: 11) | ||
| .weight(.semibold) | ||
| ) | ||
| .foregroundColor(Color(red: 0.49, green: 0.49, blue: 0.49)) |
There was a problem hiding this comment.
p3;
색상값도 이후에 디자인시스템을 적용시키면 될것같아요!
Comment on lines
194
to
198
| extension View { | ||
| func cornerRadius(_ radius: CGFloat, corners: UIRectCorner) -> some View { | ||
| clipShape( RoundedCorner(radius: radius, corners: corners) ) | ||
| } | ||
| } |
There was a problem hiding this comment.
p3;
extension은 폴더에 따로 분리하는게 좋아보입니다. Shared 폴더에 Extension 폴더를 만들어서 넣으면 좋을것같아요
Comment on lines
200
to
212
| struct RoundedCorner: Shape { | ||
| var radius: CGFloat = .infinity | ||
| var corners: UIRectCorner = .allCorners | ||
|
|
||
| func path(in rect: CGRect) -> Path { | ||
| let path = UIBezierPath( | ||
| roundedRect: rect, | ||
| byRoundingCorners: corners, | ||
| cornerRadii: CGSize(width: radius, height: radius) | ||
| ) | ||
| return Path(path.cgPath) | ||
| } | ||
| } |
There was a problem hiding this comment.
p3;
이친구도 디자인시스템이라는 폴더를 만들어서 공용 뷰를 관리하는게 좋아보입니다.
Comment on lines
78
to
92
| // else{ | ||
| // //mark: live location button | ||
| // Button{ | ||
| // //mark : setting map region | ||
| // if let coordinate = locationManager.userLocaiton?.coordinate{ | ||
| // locationManager.mapView.region = .init(center: coordinate, latitudinalMeters: 1000, longitudinalMeters: 1000) | ||
| // locationManager.addDraggablePin(coordinate: coordinate) | ||
| // locationManager.updatePlacemark(location: .init(latitude: coordinate.latitude, longitude: coordinate.longitude)) | ||
| // | ||
| // //mark: navigaiting to mapview | ||
| // navigationTag = "MAPVIEW" | ||
| // } | ||
| // }label:{ | ||
| // Label{ | ||
| // Text("Use Current Location") |
There was a problem hiding this comment.
p2;
안쓰이는 주석은 지우거나, 주석에 대한 설명 주석을 달아놓는게 좋아보입니다.
Comment on lines
8
to
16
| import XCTest | ||
|
|
||
| final class MapkitUITestsLaunchTests: XCTestCase { | ||
|
|
||
| override class var runsForEachTargetApplicationUIConfiguration: Bool { | ||
| true | ||
| } | ||
|
|
||
| override func setUpWithError() throws { |
There was a problem hiding this comment.
p3;
테스트 파일들의 위치가 이상하네요! 없애거나 위치를 다시한번 확인해주세요!
Comment on lines
56
to
59
| func fetchPlaces(value: String){ | ||
| //mark: fetching places using mklocalsearch and asyc.await | ||
| Task{ | ||
| do{ |
There was a problem hiding this comment.
p5;
이 함수의 설명을 간단하게 해줄수있을까요?
Comment on lines
131
to
132
| await MainActor.run(body:{ | ||
| self.pickedPlaceMark = place |
There was a problem hiding this comment.
p5;
MainActor 라는 것이 무엇인지 간단하게 설명이 가능할까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 요약
새로 부여 받은 UI인 경로 목록 뷰를 제작하였습니다.
지도 장소 검색과 경로 목록 뷰를 팀 작업 파일로 옮겼습니다.
📌 변경 사항
✅ PR check list
지도 검색 부분에서 네이버 지도를 활용해서 수정을 해야하는데, 참고할 사항이나 신경쓰면 좋을 부분이 있으시면 말씀해주세요!
Linked Issue
close #43