Skip to content

Commit 6fc0005

Browse files
KevinVandyclaude
andauthored
fix(examples): Pass octane e2e on octane 0.12 (#6630)
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 parent 47733cb commit 6fc0005

37 files changed

Lines changed: 69 additions & 63 deletions

File tree

‎docs/framework/octane/guide/cell-spanning.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,12 @@ A covered cell reports a span of `0`, and the renderer skips it. This is the sam
6868
const colSpan = cell.getColSpan()
6969

7070
// A span of 0 means the cell is covered by a cell above or to its left.
71-
// Skip it. Do not render `rowSpan={0}`: in HTML that means "span to the
71+
// Skip it. Do not render `rowspan={0}`: in HTML that means "span to the
7272
// end of the row group", which merges the cell down the entire tbody.
7373
if (rowSpan === 0 || colSpan === 0) return null
7474

7575
return (
76-
<td key={cell.id} rowSpan={rowSpan} colSpan={colSpan}>
76+
<td key={cell.id} rowspan={rowSpan} colspan={colSpan}>
7777
<table.FlexRender cell={cell} />
7878
</td>
7979
)

‎docs/framework/octane/guide/column-resizing.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ How you apply these size styles to your markup is up to you, but it is pretty co
119119
```tsx
120120
<th
121121
key={header.id}
122-
colSpan={header.colSpan}
122+
colspan={header.colSpan}
123123
style={{ width: `${header.getSize()}px` }}
124124
>
125125
```

‎docs/framework/octane/guide/expanding.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ const table = useTable({
146146
{row.getIsExpanded() && (
147147
<tr>
148148
{/* span however many columns the expanded data needs if it does not share the parent row's columns */}
149-
<td colSpan={row.getAllCells().length}>
149+
<td colspan={row.getAllCells().length}>
150150
{/* Your custom UI goes here */}
151151
</td>
152152
</tr>

‎examples/octane/aggregation/src/main.tsrx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ function App() @{
218218
{table.getFooterGroups().map((group) => (
219219
<tr key={group.id}>
220220
{group.headers.map((header) => (
221-
<th key={header.id} colSpan={header.colSpan}>
221+
<th key={header.id} colspan={header.colSpan}>
222222
{header.isPlaceholder ? null : (
223223
<table.FlexRender footer={header} />
224224
)}

‎examples/octane/basic-dynamic-columns/src/main.tsrx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ function App() @{
191191
@for (const headerGroup of table.getHeaderGroups(); key headerGroup.id) {
192192
<tr>
193193
@for (const header of headerGroup.headers; key header.id) {
194-
<th colSpan={header.colSpan}>
194+
<th colspan={header.colSpan}>
195195
{header.isPlaceholder ? null : <>
196196
<div
197197
className={header.column.getCanSort() ? 'sortable-header' : ''}

‎examples/octane/basic-external-atoms/src/main.tsrx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ function App() @{
8888
@for (const headerGroup of table.getHeaderGroups(); key headerGroup.id) {
8989
<tr>
9090
@for (const header of headerGroup.headers; key header.id) {
91-
<th colSpan={header.colSpan}>
91+
<th colspan={header.colSpan}>
9292
{header.isPlaceholder ? null : <div
9393
className={header.column.getCanSort() ? 'sortable-header' : ''}
9494
onClick={header.column.getToggleSortingHandler()}

‎examples/octane/basic-external-atoms/tests/e2e/smoke.spec.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,11 @@ test('updates pagination atom and row model without errors', async ({
3131
await expect(status).toContainText('1 of 100')
3232
const timing = await page
3333
.getByRole('button', { name: '>', exact: true })
34-
.evaluate((button) => {
34+
.evaluate(async (button) => {
3535
const started = performance.now()
3636
;(button as HTMLButtonElement).click()
37+
// Octane commits a click's updates in the next microtask.
38+
await Promise.resolve()
3739
return {
3840
elapsed: performance.now() - started,
3941
status: document.querySelector('.controls strong')?.textContent,
@@ -48,9 +50,10 @@ test('updates pagination atom and row model without errors', async ({
4850
const sortTiming = await page
4951
.locator('.sortable-header')
5052
.first()
51-
.evaluate((header) => {
53+
.evaluate(async (header) => {
5254
const started = performance.now()
5355
;(header as HTMLElement).click()
56+
await Promise.resolve()
5457
return {
5558
elapsed: performance.now() - started,
5659
text: header.textContent,

‎examples/octane/basic-external-state/src/main.tsrx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ function App() @{
9393
@for (const headerGroup of table.getHeaderGroups(); key headerGroup.id) {
9494
<tr>
9595
@for (const header of headerGroup.headers; key header.id) {
96-
<th colSpan={header.colSpan}>
96+
<th colspan={header.colSpan}>
9797
{header.isPlaceholder ? null : <div
9898
className={header.column.getCanSort() ? 'sortable-header' : ''}
9999
onClick={header.column.getToggleSortingHandler()}

‎examples/octane/basic-external-state/tests/e2e/smoke.spec.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,11 @@ test('advances controlled pagination repeatedly without render-phase errors', as
3737
const status = page.getByText(/^Page$/).locator('..')
3838
await expect(status).toContainText('1 of 100')
3939
const first = await firstRow(page)
40-
const timing = await next.evaluate((button) => {
40+
const timing = await next.evaluate(async (button) => {
4141
const started = performance.now()
4242
;(button as HTMLButtonElement).click()
43+
// Octane commits a click's updates in the next microtask.
44+
await Promise.resolve()
4345
return {
4446
elapsed: performance.now() - started,
4547
status: document.querySelector('.controls strong')?.textContent,
@@ -56,9 +58,10 @@ test('advances controlled pagination repeatedly without render-phase errors', as
5658
const sortTiming = await page
5759
.locator('.sortable-header')
5860
.first()
59-
.evaluate((header) => {
61+
.evaluate(async (header) => {
6062
const started = performance.now()
6163
;(header as HTMLElement).click()
64+
await Promise.resolve()
6265
return {
6366
elapsed: performance.now() - started,
6467
text: header.textContent,

‎examples/octane/basic-subscribe/src/main.tsrx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ function App() @{
139139
@for (const headerGroup of table.getHeaderGroups(); key headerGroup.id) {
140140
<tr>
141141
@for (const header of headerGroup.headers; key header.id) {
142-
<th colSpan={header.colSpan}>
142+
<th colspan={header.colSpan}>
143143
{header.isPlaceholder ? null : <>
144144
<table.FlexRender header={header} />
145145
{header.column.getCanFilter()
@@ -175,7 +175,7 @@ function App() @{
175175
/>}
176176
</table.Subscribe>
177177
</td>
178-
<td colSpan={20}>
178+
<td colspan={20}>
179179
Page Rows ({String(table.getRowModel().rows.length)})
180180
</td>
181181
</tr>

0 commit comments

Comments
 (0)