fix(angular): revisit adapter to support lazy initialization

Author: riccardoperra

packages/angular-table/src/injectTable.ts

@@ -98,42 +98,47 @@ export function injectTable<
   const injector = inject(Injector)
   const ngZone = inject(NgZone)
   const options = computed(() => _options())
+  const coreReactivityFeature = angularReactivity(injector)
+
+  let table: Table<TFeatures, TData>
+  injector.get(DestroyRef).onDestroy(() => {
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
+    if (table) {
+      table._reactivity.unmount?.()
+    }
+  })
+
+  let previousOptions: TableOptions<TFeatures, TData>
+  effect(
+    () => {
+      const currentOptions = options()
+      // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
+      if (!table) {
+        return
+      }
+      if (previousOptions === currentOptions) {
+        return
+      }
+      untracked(() =>
+        table.setOptions((previous) => ({
+          ...previous,
+          ...currentOptions,
+        })),
+      )
+      previousOptions = currentOptions
+    },
+    { injector, debugName: 'tableOptionsUpdate' },
+  )
 
   return ngZone.runOutsideAngular(() =>
     lazyInit(() => {
-      // Explicit type arguments skip generic inference from the spread object
-      // (a type-check hot spot); the spread only adds the angular reactivity
-      // binding to `features`.
-      const table = constructTable<TFeatures, TData>({
+      table = constructTable<TFeatures, TData>({
         ...options(),
         features: {
-          coreReactivityFeature: angularReactivity(injector),
+          coreReactivityFeature,
           ...options().features,
         },
       })
-
-      injector.get(DestroyRef).onDestroy(() => {
-        table._reactivity.unmount?.()
-      })
-
-      let previousOptions = options()
-      effect(
-        () => {
-          const currentOptions = options()
-          if (previousOptions === currentOptions) {
-            return
-          }
-          untracked(() =>
-            table.setOptions((previous) => ({
-              ...previous,
-              ...currentOptions,
-            })),
-          )
-          previousOptions = currentOptions
-        },
-        { injector, debugName: 'tableOptionsUpdate' },
-      )
-
       return table
     }),
   )

packages/angular-table/src/lazySignalInitializer.ts

@@ -13,8 +13,6 @@ export function lazyInit<T extends object>(initializer: () => T): T {
     }
   }
 
-  queueMicrotask(() => initializeObject())
-
   const table = () => {}
 
   return new Proxy<T>(table as T, {

packages/angular-table/tests/lazy-init.test.ts

@@ -13,7 +13,7 @@ import { flushQueue, setFixtureSignalInputs } from './test-utils'
 import type { WritableSignal } from '@angular/core'
 
 describe('lazyInit', () => {
-  test('should init lazily in next tick when not accessing manually', async () => {
+  test('should not init lazily in next tick when not accessing manually', async () => {
     const mockFn = vi.fn()
 
     TestBed.runInInjectionContext(() => {
@@ -29,7 +29,7 @@ describe('lazyInit', () => {
 
     await new Promise(setImmediate)
 
-    expect(mockFn).toHaveBeenCalled()
+    expect(mockFn).not.toHaveBeenCalled()
   })
 
   test('should init eagerly accessing manually', () => {