Skip to content

Commit 490ae51

Browse files
committed
CLAP-59 Fix: 승인대기중 닉네임 필터링 시 requestor와 processor 분리
1 parent 77c0d24 commit 490ae51

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

src/main/java/clap/server/adapter/inbound/web/dto/task/FilterTaskListRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public record FilterTaskListRequest(
2424
@NotNull
2525
String title,
2626

27-
@Schema(description = "사용자 닉네임", example = "atom.park")
27+
@Schema(description = "요청자/처리자 닉네임", example = "atom.park")
2828
@NotNull
2929
String nickName,
3030

src/main/java/clap/server/adapter/outbound/persistense/repository/task/TaskCustomRepositoryImpl.java

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,22 +26,28 @@ public class TaskCustomRepositoryImpl implements TaskCustomRepository {
2626
private final JPAQueryFactory queryFactory;
2727

2828
@Override
29-
public Page<TaskEntity> findTasksRequestedByUser(Long requesterId, Pageable pageable, FilterTaskListRequest findTaskListRequest) {
30-
BooleanBuilder whereClause = createFilter(findTaskListRequest);
29+
public Page<TaskEntity> findTasksRequestedByUser(Long requesterId, Pageable pageable, FilterTaskListRequest filterTaskListRequest) {
30+
BooleanBuilder whereClause = createFilter(filterTaskListRequest);
31+
if (!filterTaskListRequest.nickName().isEmpty()) {
32+
whereClause.and(taskEntity.processor.nickname.eq(filterTaskListRequest.nickName()));
33+
}
3134
whereClause.and(taskEntity.requester.memberId.eq(requesterId));
32-
return getTasksPage(pageable, whereClause, findTaskListRequest.orderRequest().sortBy(), findTaskListRequest.orderRequest().sortDirection());
35+
36+
return getTasksPage(pageable, whereClause, filterTaskListRequest.orderRequest().sortBy(), filterTaskListRequest.orderRequest().sortDirection());
3337
}
3438

3539
@Override
3640
public Page<TaskEntity> findPendingApprovalTasks(Pageable pageable, FilterTaskListRequest filterTaskListRequest) {
3741
BooleanBuilder whereClause = createFilter(filterTaskListRequest);
42+
if (!filterTaskListRequest.nickName().isEmpty()) {
43+
whereClause.and(taskEntity.requester.nickname.eq(filterTaskListRequest.nickName()));
44+
}
3845
whereClause.and(taskEntity.taskStatus.eq(TaskStatus.REQUESTED));
3946
return getTasksPage(pageable, whereClause, filterTaskListRequest.orderRequest().sortBy(), filterTaskListRequest.orderRequest().sortDirection());
4047
}
4148

4249
private BooleanBuilder createFilter(FilterTaskListRequest request) {
4350
BooleanBuilder whereClause = new BooleanBuilder();
44-
4551
if (request.term() != null) {
4652
LocalDateTime fromDate = LocalDateTime.now().minusHours(request.term());
4753
whereClause.and(taskEntity.createdAt.after(fromDate));
@@ -55,9 +61,6 @@ private BooleanBuilder createFilter(FilterTaskListRequest request) {
5561
if (!request.title().isEmpty()) {
5662
whereClause.and(taskEntity.title.containsIgnoreCase(request.title()));
5763
}
58-
if (!request.nickName().isEmpty()) {
59-
whereClause.and(taskEntity.processor.nickname.eq(request.nickName()));
60-
}
6164
if (!request.taskStatus().isEmpty()) {
6265
whereClause.and(taskEntity.taskStatus.in(request.taskStatus()));
6366
}

0 commit comments

Comments
 (0)