Skip to content

Commit 5af9c4d

Browse files
committed
CLAP-108 Fix: comment에 달리지 않은 attachment만 조회
1 parent d42e522 commit 5af9c4d

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

src/main/java/clap/server/adapter/outbound/persistense/AttachmentPersistenceAdapter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ public void saveAll(List<Attachment> attachments) {
3838
}
3939

4040
@Override
41-
public List<Attachment> findAllByTaskId(final Long taskId) {
42-
List<AttachmentEntity> attachmentEntities = attachmentRepository.findAllByTask_TaskId(taskId);
41+
public List<Attachment> findAllByTaskIdAndCommentIsNull(final Long taskId) {
42+
List<AttachmentEntity> attachmentEntities = attachmentRepository.findAllByTask_TaskIdAndCommentIsNull(taskId);
4343
return attachmentEntities.stream()
4444
.map(attachmentPersistenceMapper::toDomain)
4545
.collect(Collectors.toList());

src/main/java/clap/server/adapter/outbound/persistense/entity/task/CommentEntity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public class CommentEntity extends BaseTimeEntity {
2727
@JoinColumn(name = "task_id", nullable = false)
2828
private TaskEntity task;
2929

30-
@Column(name = "content", nullable = false)
30+
@Column(name = "content", nullable = false) //nullable false인 이유
3131
private String content;
3232

3333
@Column(name = "is_modified", nullable = false)

src/main/java/clap/server/adapter/outbound/persistense/repository/task/AttachmentRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
@Repository
99
public interface AttachmentRepository extends JpaRepository<AttachmentEntity, Long> {
10-
List<AttachmentEntity> findAllByTask_TaskId(Long taskId);
10+
List<AttachmentEntity> findAllByTask_TaskIdAndCommentIsNull(Long taskId);
1111
void deleteAllByAttachmentIdIn(List<Long> attachmentIds);
1212

1313
}

src/main/java/clap/server/application/port/outbound/task/LoadAttachmentPort.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@
66

77

88
public interface LoadAttachmentPort {
9-
List<Attachment> findAllByTaskId(Long task);
9+
List<Attachment> findAllByTaskIdAndCommentIsNull(Long task);
1010
}

src/main/java/clap/server/application/service/Task/FindTaskDetailsService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public List<FindTaskDetailsResponse> findRequestedTaskDetails(final Long request
3232
memberService.findActiveMember(requesterId);
3333
Task task = loadTaskPort.findById(taskId)
3434
.orElseThrow(()-> new ApplicationException(TaskErrorCode.TASK_NOT_FOUND));
35-
List<Attachment> attachments = loadAttachmentPort.findAllByTaskId(taskId); //TODO: comment에 달린 이미지 첨부파일은 가져오지 않도록 수정
35+
List<Attachment> attachments = loadAttachmentPort.findAllByTaskIdAndCommentIsNull(taskId);
3636
return TaskMapper.toFindTaskDetailResponses(task, attachments);
3737
}
3838
}

0 commit comments

Comments
 (0)