Skip to content

Commit 6837365

Browse files
committed
CLAP-200 Fix: 파일 배열에 대해 null 체크 추가
<footer> - 관련: #202
1 parent 3a0e8e1 commit 6837365

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

src/main/java/clap/server/application/service/task/CreateTaskService.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,10 @@ public CreateTaskResponse createTask(Long requesterId, CreateTaskRequest createT
5555
savedTask.setInitialProcessorOrder();
5656
commandTaskPort.save(savedTask);
5757

58-
saveAttachments(files, savedTask);
58+
if (files != null) {
59+
saveAttachments(files, savedTask);
60+
}
61+
5962
publishNotification(savedTask);
6063
return TaskMapper.toCreateTaskResponse(savedTask);
6164
}
@@ -66,7 +69,7 @@ private void saveAttachments(List<MultipartFile> files, Task task) {
6669
commandAttachmentPort.saveAll(attachments);
6770
}
6871

69-
private void publishNotification(Task task){
72+
private void publishNotification(Task task) {
7073
List<Member> reviewers = memberService.findReviewers();
7174

7275
// 검토자들 각각에 대한 알림 생성 후 event 발행
@@ -90,5 +93,4 @@ private void publishNotification(Task task){
9093
}
9194

9295

93-
9496
}

src/main/java/clap/server/application/service/task/UpdateTaskService.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,11 @@ private void updateAttachments(List<Long> attachmentIdsToDelete, List<MultipartF
122122
List<Attachment> attachmentsToDelete = validateAndGetAttachments(attachmentIdsToDelete, task);
123123
attachmentsToDelete.forEach(Attachment::softDelete);
124124

125-
List<String> fileUrls = s3UploadAdapter.uploadFiles(FilePathConstants.TASK_IMAGE, files);
126-
List<Attachment> attachments = AttachmentMapper.toTaskAttachments(task, files, fileUrls);
127-
commandAttachmentPort.saveAll(attachments);
125+
if(files != null) {
126+
List<String> fileUrls = s3UploadAdapter.uploadFiles(FilePathConstants.TASK_IMAGE, files);
127+
List<Attachment> attachments = AttachmentMapper.toTaskAttachments(task, files, fileUrls);
128+
commandAttachmentPort.saveAll(attachments);
129+
}
128130
}
129131

130132
private List<Attachment> validateAndGetAttachments(List<Long> attachmentIdsToDelete, Task task) {

0 commit comments

Comments
 (0)