Skip to content

Commit 788052b

Browse files
committed
CLAP-425 Fix: 로그인에서 닉네임으로 사용자 조회 시 active한 회원들에 대해서만 조회되도록 수정
<footer> - #554
1 parent 7730d67 commit 788052b

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

src/main/java/clap/server/adapter/outbound/persistense/MemberPersistenceAdapter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ public Optional<Member> findActiveMemberById(final Long id) {
3838
}
3939

4040
@Override
41-
public Optional<Member> findByNickname(final String nickname) {
42-
Optional<MemberEntity> memberEntity = memberRepository.findByNickname(nickname);
41+
public Optional<Member> findActiveMemberByNickname(final String nickname) {
42+
Optional<MemberEntity> memberEntity = memberRepository.findActiveMemberByNickname(nickname);
4343
return memberEntity.map(memberPersistenceMapper::toDomain);
4444
}
4545

src/main/java/clap/server/adapter/outbound/persistense/repository/member/MemberRepository.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ public interface MemberRepository extends JpaRepository<MemberEntity, Long>, Me
1818

1919
Optional<MemberEntity> findByStatusAndMemberId(MemberStatus memberStatus, Long memberId);
2020

21-
Optional<MemberEntity> findByNickname(String nickname);
21+
@Query("SELECT m FROM MemberEntity m WHERE m.nickname = :nickname AND m.status = 'ACTIVE'")
22+
Optional<MemberEntity> findActiveMemberByNickname(@Param("nickname") String nickname);
2223

2324
List<MemberEntity> findByIsReviewerTrue();
2425

src/main/java/clap/server/application/port/outbound/member/LoadMemberPort.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22

33
import clap.server.adapter.inbound.web.dto.admin.request.FindMemberRequest;
44
import clap.server.domain.model.member.Member;
5-
import clap.server.domain.model.task.Task; // Task 클래스 임포트 확인
6-
import clap.server.adapter.outbound.persistense.entity.task.constant.TaskStatus; // TaskStatus 임포트
5+
76
import java.util.List;
87
// Task 클래스 임포트 확인
98
// TaskStatus 임포트
@@ -22,7 +21,7 @@ public interface LoadMemberPort {
2221

2322
Optional<Member> findReviewerById(Long id);
2423

25-
Optional<Member> findByNickname(String nickname);
24+
Optional<Member> findActiveMemberByNickname(String nickname);
2625

2726
List<Member> findReviewers();
2827

src/main/java/clap/server/application/service/auth/AuthService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ private void deleteAccessToken(Long memberId, String accessToken) {
6969
}
7070

7171
private Member getMember(String inputNickname, String clientIp) {
72-
return loadMemberPort.findByNickname(inputNickname).orElseThrow(() ->
72+
return loadMemberPort.findActiveMemberByNickname(inputNickname).orElseThrow(() ->
7373
{
7474
loginAttemptService.recordFailedAttempt(inputNickname, clientIp);
7575
return new AuthException(AuthErrorCode.LOGIN_REQUEST_FAILED);

0 commit comments

Comments
 (0)