Skip to content

Commit 88a074c

Browse files
committed
CLAP-153 Fix: 불필요한 주석 및 로직 제거
1 parent 022670b commit 88a074c

File tree

3 files changed

+1
-15
lines changed

3 files changed

+1
-15
lines changed

src/main/java/clap/server/adapter/outbound/persistense/TaskHistoryPersistenceAdapter.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,6 @@ public class TaskHistoryPersistenceAdapter implements LoadTaskHistoryPort {
1919
private final TaskHistoryRepository taskHistoryRepository;
2020
private final TaskHistoryPersistenceMapper taskHistoryPersistenceMapper;
2121

22-
@Override
23-
public List<TaskHistory> findAllByTaskIdNotInComment(Long taskId) {
24-
return taskHistoryRepository.findAllByTaskModificationInfo_Task_TaskId(taskId)
25-
.stream()
26-
.map(taskHistoryPersistenceMapper::toDomain)
27-
.toList();
28-
}
29-
3022
@Override
3123
public List<TaskHistory> findAllTaskHistoriesByTaskId(Long taskId) {
3224
return taskHistoryRepository.findAllTaskHistoriesByTaskId(taskId)

src/main/java/clap/server/application/port/outbound/task/LoadTaskHistoryPort.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,5 @@
66
import java.util.List;
77

88
public interface LoadTaskHistoryPort {
9-
List<TaskHistory> findAllByTaskIdNotInComment(Long taskId);
109
List<TaskHistory> findAllTaskHistoriesByTaskId(Long taskId);
1110
}

src/main/java/clap/server/application/service/task/FindTaskHistoriesService.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import clap.server.application.port.inbound.domain.MemberService;
66
import clap.server.application.port.inbound.task.FindTaskHistoriesUsecase;
77
import clap.server.application.port.outbound.task.LoadAttachmentPort;
8-
import clap.server.application.port.outbound.task.LoadCommentPort;
8+
99
import clap.server.application.port.outbound.task.LoadTaskHistoryPort;
1010
import clap.server.application.port.outbound.task.LoadTaskPort;
1111
import clap.server.common.annotation.architecture.ApplicationService;
@@ -36,10 +36,5 @@ public FindTaskHistoryResponse findTaskHistories(Long memberId, Long taskId) {
3636
List<Attachment> attachments = loadAttachmentPort.findAllByTaskIdAndCommentIsNotNull(task.getTaskId());
3737
List<TaskHistory> taskHistories = loadTaskHistoryPort.findAllTaskHistoriesByTaskId(task.getTaskId());
3838
return TaskHistoryMapper.toFindTaskHistoryResponse(taskHistories, attachments);
39-
40-
//task가 fk로 있고 comment가 null인 taskhisotry 를 가져온다
41-
//List<TaskHistory> taskHistoriesNotComment = loadTaskHistoryPort.findAllByTaskIdNotInComment(taskId);
42-
//task가 fk로 있는 comment를 가져오고 comment fk로 있는 taskhistory를 가져온다.
43-
//task가 fk로 있는 comment를 가져오고 comment fk로 있는 attachment와 taskhistory를 가져온다.
4439
}
4540
}

0 commit comments

Comments
 (0)