Skip to content

Commit e42d5ee

Browse files
committed
CLAP-56 Fix: 매개변수 final 설정을 통한 불변성 유지
1 parent 25e46c4 commit e42d5ee

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/main/java/clap/server/adapter/outbound/persistense/AttachmentPersistenceAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public void saveAll(List<Attachment> attachments) {
3838
}
3939

4040
@Override
41-
public List<Attachment> findAllByTaskId(Long taskId) {
41+
public List<Attachment> findAllByTaskId(final Long taskId) {
4242
List<AttachmentEntity> attachmentEntities = attachmentRepository.findAllByTask_TaskId(taskId);
4343
return attachmentEntities.stream()
4444
.map(attachmentPersistenceMapper::toDomain)

src/main/java/clap/server/adapter/outbound/persistense/entity/task/TaskHistoryEntity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public class TaskHistoryEntity extends BaseTimeEntity {
2626
@Embedded
2727
private TaskModificationInfo taskModificationInfo;
2828

29-
@ManyToOne(fetch = FetchType.LAZY)
29+
@OneToOne(fetch = FetchType.LAZY)
3030
@JoinColumn(name = "comment_id")
3131
private CommentEntity comment;
3232
}

src/main/java/clap/server/adapter/outbound/persistense/entity/task/TaskModificationInfo.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ public class TaskModificationInfo {
1414
private TaskEntity task;
1515

1616
@Column(name = "modified_field")
17-
private String modifiedField;
17+
private String modifiedField; //처리자(requestor) / 요청상태(taskStatus) -> task 상태 변경 혹은 처리 변경시에 taskhistory 테이블도 변경해야함
1818

1919
@ManyToOne(fetch = FetchType.LAZY)
20-
@JoinColumn(name = "modified_member_id")
20+
@JoinColumn(name = "modified_member_id") //처리자가 바뀌는 경우
2121
private MemberEntity member;
2222

2323
@Column(name = "new_value")
24-
private String newValue;
24+
private String newValue; //상태가 바뀌는 경우
2525
}

0 commit comments

Comments
 (0)