Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more flexible on path value: must be absolute if not Windows Store target #105

Closed
ianwieds opened this issue Jan 10, 2021 · 19 comments · Fixed by #120 or #126
Closed

Be more flexible on path value: must be absolute if not Windows Store target #105

ianwieds opened this issue Jan 10, 2021 · 19 comments · Fixed by #120 or #126
Assignees
Milestone

Comments

@ianwieds
Copy link

  • The target platform(s) the problem occurs on (Linux, Mac, Mac App Store, and or Windows): Windows Store
  • Node version (run node -v): v12.18.3
  • auto-launch version: 5.0.5
  • The options you're passing to auto-launch: name, path
  • Are you using NW.js or Electron?
    • If so, which version?: 11.1.1 (latest as of now)
    • If you're using Electron, are you using auto-launch from the main process or a renderer process? main
  • Can you reproduce this with a simple Hello World example app? yes
  • If needs be, would you be able to provide us with a simple app (as simple as possible) which reproduces the problem?

We are trying out a test to see how this works for Windows Store but we're getting an error: path must be absolute

  const autoLaunch = new AutoLaunch({
    name: 'OurApp',
    path: 'explorer.exe shell:AppsFolder\\OurCompany.OurApp_abcd123456!OurCompany.OurApp',
  });

// The error throws immediately: 'path must be absolute'

We followed the instructions in the docs. Any help would be appreciated!

@jurkog
Copy link

jurkog commented Apr 7, 2021

Running in to the same issue, any update on this?

@racoonman
Copy link

This issue is still occurring, any update?

@miguelx97
Copy link

Hello!
I've just made a new PR solving this problem with Microsoft store appx: #111
Example of how you can instance autoLaunch: new autoLaunch({ name: 'APP_NAME', path:"DEV_ID.APP_ID!PACKAGE_NAME", isHidden: true })

I hope you find it useful :)

@serkanyazicioglu
Copy link

I guess @Teamwork members don't look at here anymore 😢

@hovancik
Copy link

hovancik commented Jul 2, 2023

Please merge the fix :)

@Oxalin Oxalin self-assigned this Dec 4, 2023
@Oxalin Oxalin changed the title path must be absolute (Windows Store target) Be more flexible on path value: must be absolute if not Windows Store target Dec 4, 2023
@Oxalin
Copy link
Contributor

Oxalin commented Dec 12, 2023

The next version bump will include support for Windows AppX, the code has been merged and reworked.

@Oxalin
Copy link
Contributor

Oxalin commented Jan 20, 2024

Thanks to @miguelx97 for the PR. I based the feature on your code with some tweaks. This should be available from 5.1.0.

@Oxalin Oxalin closed this as completed Jan 20, 2024
@Oxalin
Copy link
Contributor

Oxalin commented Jan 20, 2024

Please, use 5.1.0 for this feature.

@hovancik
Copy link

@Oxalin npm installs 5.0.6 , will you please update? https://www.npmjs.com/package/auto-launch

@Oxalin
Copy link
Contributor

Oxalin commented Feb 23, 2024 via email

@Oxalin
Copy link
Contributor

Oxalin commented Feb 23, 2024 via email

@Oxalin
Copy link
Contributor

Oxalin commented Feb 26, 2024

@4ver @adam-lynch Any possibility for one of you to add either add me under npmjs for the project or to launch a "npm publish" on your side?

@hovancik
Copy link

@Oxalin I am trying to install from github with npm i Teamwork/node-auto-launch but getting error when trying to use it:

Error: Cannot find module 'C:\Users\conta\stretchly\node_modules\auto-launch\dist\index.js'. Please verify that the package.json has a valid "main" entry
    at tryPackage (node:internal/modules/cjs/loader:445:19)
    at Module._findPath (node:internal/modules/cjs/loader:687:18)
    at Module._resolveFilename (node:internal/modules/cjs/loader:1070:27)
    at n._resolveFilename (node:electron/js2c/browser_init:2:114728)
    at Module._load (node:internal/modules/cjs/loader:929:27)
    at l._load (node:electron/js2c/asar_bundle:2:13642)
    at Module.require (node:internal/modules/cjs/loader:1150:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at App.initialize (C:\Users\conta\stretchly\app\main.js:226:20)
    at App.emit (node:events:529:35)

@4ver
Copy link
Member

4ver commented Feb 26, 2024

I'll add a ghaction to build and publish to npm today 👍

@Oxalin I am trying to install from github with npm i Teamwork/node-auto-launch but getting error when trying to use it:

There's no dist directory pushed to github so installing the package from gh won't work.

@Oxalin
Copy link
Contributor

Oxalin commented Feb 27, 2024

I'll fix it. I didn't know that was a prerequiste.

@4ver
Copy link
Member

4ver commented Feb 27, 2024

It's not a prerequisite/we don't want to push the js 👌

@4ver
Copy link
Member

4ver commented Feb 27, 2024

I just setup automatic publishes to npm when releases are published on github.

To release, create a tag and release with the same name (semver version number) as seen here:

Screenshot 2024-02-27 at 15 59 06

You can release to a beta channel on npm by adding -rcX to the end of the release version. If you don't add -rcX it will release to production. Please take care when making releases that you use the correct version numbers.

Ping me if you want to release to production.

@4ver
Copy link
Member

4ver commented Feb 27, 2024

Also fyi, i released version 6.0.0-rc1 with the changes from master https://github.com/Teamwork/node-auto-launch/releases/tag/6.0.0-rc1

@Oxalin
Copy link
Contributor

Oxalin commented Mar 19, 2024

Thank you! I'm short on time right now and I haven't had the time to deal my own not-committed changes.

@Oxalin Oxalin linked a pull request Mar 22, 2024 that will close this issue
@Oxalin Oxalin linked a pull request Apr 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment