Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra rules when filtering by domain #22

Open
igvk opened this issue May 27, 2019 · 0 comments
Open

Extra rules when filtering by domain #22

igvk opened this issue May 27, 2019 · 0 comments

Comments

@igvk
Copy link

igvk commented May 27, 2019

Initially mentioned in #21.
When getting all filters for domain by GetFiltersForDomain(domain), there are rules that shouldn't be there, because they correspond to some other domains (with domain option).

Here are examples taken from Easylist.

Whitelist rule:
@@||www.google.com/adsense/search/async-ads.js$domain=webcrawler.com
If I call GetWhitelistFiltersForDomain("www.google.com"), I still get this filter in the enumeration, although it definitely is relevant only for the domain webcrawler.com.

Blacklist rule:
||google.com/jsapi?autoload=*%22ads%22$script,domain=youtube.com
and the call to GetFiltersForDomain("www.google.com").
kurema added a commit to kurema/BookViewerApp3 that referenced this issue Dec 3, 2022
@kurema
Bug fix
3d8f571 
It seems "ApplicableDomains" is not correct.
TechnikEmpire/DistillNET#22
The last update is 3 years ago, so do I have to fork?
This looks nice.
https://github.com/THGSCST/DistillNET
kurema added a commit to kurema/DistillNET that referenced this issue Dec 4, 2022
@kurema
Fix for domain rule.
35da36f 
TechnikEmpire#22
@kurema kurema mentioned this issue Dec 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@igvk