Skip to content

Commit d4f44ae

Browse files
Technologicatclaude
andcommitted
Drop the unused flake8rc, and the three places that claimed it was used
flake8rc was a committed snapshot of the global flake8 config. Nothing read it: CI lints with ruff, and Emacs flycheck reads ~/.config/flake8 by absolute path (flycheck-flake8rc in init.el), not the project copy. It had also drifted from the global — missing F824, differing around W504 — so as documentation it was actively misleading. Three stale references went with it: - CLAUDE.md claimed it was "used by Emacs flycheck". It isn't. - coverage.yml did `pip install flake8` and then never ran flake8. Dead step. - ci.yml's header comment said the workflow was customized to "use the local flake8rc", which it isn't, and to test with `unpythonic.setup.fixtures`, which does not exist — the module is `unpythonic.test.fixtures`. The global config (~/.spacemacs.d/flake8, public repo, symlinked to ~/.config/flake8) remains the single source of truth for the legacy flake8 setup; ruff is the enforced linter. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 06c1e40 commit d4f44ae

4 files changed

Lines changed: 1 addition & 40 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
22
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions
33
#
4-
# This version is customized to install with pdm, use the local flake8rc, and test with unpythonic.setup.fixtures.
4+
# This version is customized to install with pdm, lint with ruff, and test with unpythonic.test.fixtures.
55

66
name: Python package
77

‎.github/workflows/coverage.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ jobs:
3030
- name: Install tools in CI virtualenv
3131
run: |
3232
python -m pip install --upgrade pip
33-
pip install flake8
3433
pip install pdm
3534
- name: Create in-project virtualenv and install dependencies
3635
run: |

‎CLAUDE.md‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,6 @@ Part of unpythonic's **public API** (`unpythonic.test.fixtures`, `unpythonic.tes
109109
ruff check <changed .py files> # primary linter (config in pyproject.toml)
110110
```
111111

112-
Legacy `flake8rc` also present (used by Emacs flycheck, not by CI or CC).
113-
114112
## Code structure and conventions
115113

116114
- **Regular code** in `unpythonic/`, **macros** in `unpythonic/syntax/`, **REPL networking** in `unpythonic/net/`, **dialects** in `unpythonic/dialects/`.

‎flake8rc‎

Lines changed: 0 additions & 36 deletions
This file was deleted.

0 commit comments

Comments
 (0)