Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions mcp/src/tools/gateway.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const {
mockDeleteCustomDomain,
mockGetCloudBaseManager,
mockLogCloudBaseResult,
mockGetEnvId,
} = vi.hoisted(() => ({
mockGetAccessList: vi.fn(),
mockGetDomainList: vi.fn(),
Expand All @@ -26,10 +27,12 @@ const {
mockDeleteCustomDomain: vi.fn(),
mockGetCloudBaseManager: vi.fn(),
mockLogCloudBaseResult: vi.fn(),
mockGetEnvId: vi.fn(),
}));

vi.mock("../cloudbase-manager.js", () => ({
getCloudBaseManager: mockGetCloudBaseManager,
getEnvId: mockGetEnvId,
logCloudBaseResult: mockLogCloudBaseResult,
}));

Expand Down Expand Up @@ -66,6 +69,11 @@ describe("gateway tools", () => {
beforeEach(() => {
vi.clearAllMocks();

// Mock getEnvId to return the envId from cloudBaseOptions
mockGetEnvId.mockImplementation(async (options?: { envId?: string }) => {
return options?.envId || "env-test";
});

mockGetAccessList.mockResolvedValue({
Total: 1,
EnableService: true,
Expand Down
15 changes: 8 additions & 7 deletions mcp/src/tools/gateway.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { z } from "zod";
import { getCloudBaseManager, logCloudBaseResult } from "../cloudbase-manager.js";
import { getCloudBaseManager, getEnvId, logCloudBaseResult } from "../cloudbase-manager.js";
import { ExtendedMcpServer } from "../server.js";
import { jsonContent } from "../utils/json-content.js";

Expand Down Expand Up @@ -82,7 +82,8 @@ function ensureGatewayEnvId(cloudBaseOptions?: { envId?: string }) {
export function registerGatewayTools(server: ExtendedMcpServer) {
const cloudBaseOptions = server.cloudBaseOptions;
const getManager = () => getCloudBaseManager({ cloudBaseOptions });
const getGatewayEnvId = () => ensureGatewayEnvId(cloudBaseOptions);
// Use getEnvId to resolve envId from multiple sources: cloudBaseOptions, cache, login state, or default env manager
const getGatewayEnvId = () => getEnvId(cloudBaseOptions);

const buildEnvelope = (
data: Record<string, unknown>,
Expand Down Expand Up @@ -129,7 +130,7 @@ export function registerGatewayTools(server: ExtendedMcpServer) {
const listHttpServiceRoutes = async (domain?: string) => {
const cloudbase = await getManager();
const result = await cloudbase.env.describeHttpServiceRoute({
EnvId: getGatewayEnvId(),
EnvId: await getGatewayEnvId(),
...(domain
? {
Filters: [
Expand Down Expand Up @@ -177,7 +178,7 @@ export function registerGatewayTools(server: ExtendedMcpServer) {
}

return {
EnvId: getGatewayEnvId(),
EnvId: await getGatewayEnvId(),
Domain: {
Domain: await resolveRouteDomain(domain),
Routes: [
Expand Down Expand Up @@ -423,7 +424,7 @@ export function registerGatewayTools(server: ExtendedMcpServer) {
const cloudbase = await getManager();
const domain = await resolveRouteDomain(input.domain);
const result = await cloudbase.env.deleteHttpServiceRoute({
EnvId: getGatewayEnvId(),
EnvId: await getGatewayEnvId(),
Domain: domain,
Paths: [normalizeAccessPath(routePath)],
} as any);
Expand All @@ -445,7 +446,7 @@ export function registerGatewayTools(server: ExtendedMcpServer) {
}
const cloudbase = await getManager();
const result = await cloudbase.env.bindCustomDomain({
EnvId: getGatewayEnvId(),
EnvId: await getGatewayEnvId(),
Domain: {
Domain: input.domain,
CertId: input.certificateId,
Expand All @@ -469,7 +470,7 @@ export function registerGatewayTools(server: ExtendedMcpServer) {
}
const cloudbase = await getManager();
const result = await cloudbase.env.deleteCustomDomain({
EnvId: getGatewayEnvId(),
EnvId: await getGatewayEnvId(),
Domain: input.domain,
});
logCloudBaseResult(server.logger, result);
Expand Down
Loading