✨ improved docker config

Author: samuelbelolo

Dockerfile

@@ -7,12 +7,11 @@ RUN apt-get update && \
     apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* && \
     a2enmod rewrite && a2enmod headers
 
-COPY . .
-COPY docker/apache2/apache2.conf /etc/apache2/sites-enabled/000-default.conf
-
-
 FROM base as dev
+
+## Install composer
 RUN curl -sS https://getcomposer.org/installer | php -- --install-dir=/usr/local/bin --filename=composer
 
+## Install symfony cli
 RUN curl -sS https://get.symfony.com/cli/installer | bash
 RUN mv /root/.symfony/bin/symfony /usr/local/bin/symfony

Makefile

@@ -16,7 +16,7 @@ install:
 
 start:
 	$(DOCKER_COMPOSE) up -d
-	open "http://localhost:8082"
+	open "http://localhost:8080"
 
 stop:
 	$(DOCKER_COMPOSE) down

docker-compose.yml

@@ -5,9 +5,10 @@ services:
       context: .
       target: dev
     ports:
-      - '8082:80'
+      - '8080:80'
     volumes:
       - .:/var/www/html
+      - ./docker/apache2/apache2.conf:/etc/apache2/sites-enabled/000-default.conf
 
   mongo:
     image: mongo

docker/apache2/apache2.conf

@@ -1,35 +1,15 @@
 <VirtualHost *:80>
-        # The ServerName directive sets the request scheme, hostname and port that
-        # the server uses to identify itself. This is used when creating
-        # redirection URLs. In the context of virtual hosts, the ServerName
-        # specifies what hostname must appear in the request's Host: header to
-        # match this virtual host. For the default virtual host (this file) this
-        # value is not decisive as it is used as a last resort host regardless.
-        # However, you must set it for any further virtual host explicitly.
-        ServerName localhost
+  ServerName localhost
 
-        ServerAdmin webmaster@localhost
-        DocumentRoot /var/www/html/public
+  ServerAdmin webmaster@localhost
+  DocumentRoot /var/www/html/public
 
-        <Directory /var/www/public>
-            AllowOverride All
-            Order Allow,Deny
-            Allow from All
-        </Directory>
+  <Directory /var/www/public>
+      AllowOverride All
+      Order Allow,Deny
+      Allow from All
+  </Directory>
 
-        # Available loglevels: trace8, ..., trace1, debug, info, notice, warn,
-        # error, crit, alert, emerg.
-        # It is also possible to configure the loglevel for particular
-        # modules, e.g.
-        #LogLevel info ssl:warn
-
-        ErrorLog ${APACHE_LOG_DIR}/error.log
-        CustomLog ${APACHE_LOG_DIR}/access.log combined
-
-        # For most configuration files from conf-available/, which are
-        # enabled or disabled at a global level, it is possible to
-        # include a line for only one particular virtual host. For example the
-        # following line enables the CGI configuration for this host only
-        # after it has been globally disabled with "a2disconf".
-        #Include conf-available/serve-cgi-bin.conf
+  ErrorLog ${APACHE_LOG_DIR}/error.log
+  CustomLog ${APACHE_LOG_DIR}/access.log combined
 </VirtualHost>

readme.md

@@ -14,7 +14,7 @@ make install
 make start
 ```
 
-> App should now be available on : [http://localhost:8082](http://localhost:8082/)
+> App should now be available on : [http://localhost:8080](http://localhost:8080/)
 
 ## Database