Replies: 1 comment
-
|
Sorry, forgot to include the link to the commit main...matmaer:textual:fix/message-pump-app-unknown-type |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
In
message_pump.py, theTYPE_CHECKINGbranch defines:But the
elsebranch (the actual runtime property) declares:This causes a "partially unknown type" warning on every
self.appaccess in my dev env.The fix is a one-line change to make both branches consistent:
I believe this should have zero runtime impact.
I have a PR ready if this looks reasonable, please let me know so I can add the link to the discussion in the PR, as the template instructs me to include a link. I didn't want to open an issue as it's purely about type hinting.
Beta Was this translation helpful? Give feedback.
All reactions